2019-11-12 15:48:36

by James Tai [戴志峰]

Subject: [PATCH v3 1/2] dt-bindings: arm: realtek: Document RTD1619 and Realtek Mjolnir EVB

Define compatible strings for Realtek RTD1619 SoC and Realtek Mjolnir EVB.

Signed-off-by: James Tai <[email protected]>
---
Documentation/devicetree/bindings/arm/realtek.yaml | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/realtek.yaml b/Documentation/devicetree/bindings/arm/realtek.yaml
index ab59de17152d..2444eff2c3d5 100644
--- a/Documentation/devicetree/bindings/arm/realtek.yaml
+++ b/Documentation/devicetree/bindings/arm/realtek.yaml
@@ -33,4 +33,10 @@ properties:
- enum:
- synology,ds418 # Synology DiskStation DS418
- const: realtek,rtd1296
+
+ # RTD1619 SoC based boards
+ - items:
+ - enum:
+ - realtek,mjolnir # Realtek Mjolnir EVB
+ - const: realtek,rtd1619
...
--
2.24.0

2019-11-13 21:03:17

by Andreas Färber

Subject: Re: [PATCH v3 1/2] dt-bindings: arm: realtek: Document RTD1619 and Realtek Mjolnir EVB

Am 12.11.19 um 16:45 schrieb James Tai:
> Define compatible strings for Realtek RTD1619 SoC and Realtek Mjolnir EVB.
>
> Signed-off-by: James Tai <[email protected]>
> ---

This is missing the requested change log here: What changed since v2?

If nothing changed, then you should've inserted my Reviewed-by from v2
before your Signed-off-by.

Regards,
Andreas

> Documentation/devicetree/bindings/arm/realtek.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/realtek.yaml b/Documentation/devicetree/bindings/arm/realtek.yaml
> index ab59de17152d..2444eff2c3d5 100644
> --- a/Documentation/devicetree/bindings/arm/realtek.yaml
> +++ b/Documentation/devicetree/bindings/arm/realtek.yaml
> @@ -33,4 +33,10 @@ properties:
> - enum:
> - synology,ds418 # Synology DiskStation DS418
> - const: realtek,rtd1296
> +
> + # RTD1619 SoC based boards
> + - items:
> + - enum:
> + - realtek,mjolnir # Realtek Mjolnir EVB
> + - const: realtek,rtd1619
> ...
>


--
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)

2019-11-15 14:46:41

by James Tai [戴志峰]

Subject: RE: [PATCH v3 1/2] dt-bindings: arm: realtek: Document RTD1619 and Realtek Mjolnir EVB

Hi Andreas,

> > Define compatible strings for Realtek RTD1619 SoC and Realtek Mjolnir EVB.
> >
> > Signed-off-by: James Tai <[email protected]>
> > ---
>
> This is missing the requested change log here: What changed since v2?
>
> If nothing changed, then you should've inserted my Reviewed-by from v2
> before your Signed-off-by.
>

There is nothing changed. I'll correct the mistakes in next version.

2019-11-18 17:53:11

by Rob Herring (Arm)

Subject: Re: [PATCH v3 1/2] dt-bindings: arm: realtek: Document RTD1619 and Realtek Mjolnir EVB

On Tue, 12 Nov 2019 15:45:13 +0000, James Tai wrote:
>
> Define compatible strings for Realtek RTD1619 SoC and Realtek Mjolnir EVB.
>
> Signed-off-by: James Tai <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/realtek.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>

Reviewed-by: Rob Herring <[email protected]>

2019-12-28 14:22:12

by Andreas Färber

Subject: Re: [PATCH v3 1/2] dt-bindings: arm: realtek: Document RTD1619 and Realtek Mjolnir EVB

Am 18.11.19 um 18:50 schrieb Rob Herring:
> On Tue, 12 Nov 2019 15:45:13 +0000, James Tai wrote:
>>
>> Define compatible strings for Realtek RTD1619 SoC and Realtek Mjolnir EVB.
>>
>> Signed-off-by: James Tai <[email protected]>
>> ---
>> Documentation/devicetree/bindings/arm/realtek.yaml | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>
> Reviewed-by: Rob Herring <[email protected]>

Applied to v5.6/dt:

https://git.kernel.org/pub/scm/linux/kernel/git/afaerber/linux-realtek.git/log/?h=v5.6/dt

Thanks,
Andreas

--
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)