2023-04-07 02:47:07

by Tiezhu Yang

[permalink] [raw]
Subject: [PATCH bpf-next] tools headers: Remove s390 ptrace.h in check-headers.sh

After commit 1f265d2aea0d ("selftests/bpf: Remove not used headers"),
tools/arch/s390/include/uapi/asm/ptrace.h has been removed, so remove
it in check-headers.sh too, otherwise we can see the following build
warning:

diff: tools/arch/s390/include/uapi/asm/ptrace.h: No such file or directory

Reported-by: kernel test robot <[email protected]>
Link: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Fixes: 1f265d2aea0d ("selftests/bpf: Remove not used headers")
Signed-off-by: Tiezhu Yang <[email protected]>
---

commit 1f265d2aea0d ("selftests/bpf: Remove not used headers") is in
bpf-next tree, so I prefer this patch can be applied to bpf-next tree.

tools/perf/check-headers.sh | 1 -
1 file changed, 1 deletion(-)

diff --git a/tools/perf/check-headers.sh b/tools/perf/check-headers.sh
index eacca9a..e4a8b53 100755
--- a/tools/perf/check-headers.sh
+++ b/tools/perf/check-headers.sh
@@ -52,7 +52,6 @@ arch/x86/include/uapi/asm/vmx.h
arch/powerpc/include/uapi/asm/kvm.h
arch/s390/include/uapi/asm/kvm.h
arch/s390/include/uapi/asm/kvm_perf.h
-arch/s390/include/uapi/asm/ptrace.h
arch/s390/include/uapi/asm/sie.h
arch/arm/include/uapi/asm/kvm.h
arch/arm64/include/uapi/asm/kvm.h
--
2.1.0


2023-04-07 10:45:58

by Jiri Olsa

[permalink] [raw]
Subject: Re: [PATCH bpf-next] tools headers: Remove s390 ptrace.h in check-headers.sh

On Fri, Apr 07, 2023 at 10:21:30AM +0800, Tiezhu Yang wrote:
> After commit 1f265d2aea0d ("selftests/bpf: Remove not used headers"),
> tools/arch/s390/include/uapi/asm/ptrace.h has been removed, so remove
> it in check-headers.sh too, otherwise we can see the following build
> warning:
>
> diff: tools/arch/s390/include/uapi/asm/ptrace.h: No such file or directory
>
> Reported-by: kernel test robot <[email protected]>
> Link: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Fixes: 1f265d2aea0d ("selftests/bpf: Remove not used headers")
> Signed-off-by: Tiezhu Yang <[email protected]>

not sure this should go through Arnaldo's tree instead,
either way is fine with me

Acked-by: Jiri Olsa <[email protected]>

jirka

> ---
>
> commit 1f265d2aea0d ("selftests/bpf: Remove not used headers") is in
> bpf-next tree, so I prefer this patch can be applied to bpf-next tree.
>
> tools/perf/check-headers.sh | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/perf/check-headers.sh b/tools/perf/check-headers.sh
> index eacca9a..e4a8b53 100755
> --- a/tools/perf/check-headers.sh
> +++ b/tools/perf/check-headers.sh
> @@ -52,7 +52,6 @@ arch/x86/include/uapi/asm/vmx.h
> arch/powerpc/include/uapi/asm/kvm.h
> arch/s390/include/uapi/asm/kvm.h
> arch/s390/include/uapi/asm/kvm_perf.h
> -arch/s390/include/uapi/asm/ptrace.h
> arch/s390/include/uapi/asm/sie.h
> arch/arm/include/uapi/asm/kvm.h
> arch/arm64/include/uapi/asm/kvm.h
> --
> 2.1.0
>

2023-04-11 17:40:19

by Daniel Borkmann

[permalink] [raw]
Subject: Re: [PATCH bpf-next] tools headers: Remove s390 ptrace.h in check-headers.sh

On 4/7/23 12:27 PM, Jiri Olsa wrote:
> On Fri, Apr 07, 2023 at 10:21:30AM +0800, Tiezhu Yang wrote:
>> After commit 1f265d2aea0d ("selftests/bpf: Remove not used headers"),
>> tools/arch/s390/include/uapi/asm/ptrace.h has been removed, so remove
>> it in check-headers.sh too, otherwise we can see the following build
>> warning:
>>
>> diff: tools/arch/s390/include/uapi/asm/ptrace.h: No such file or directory
>>
>> Reported-by: kernel test robot <[email protected]>
>> Link: https://lore.kernel.org/oe-kbuild-all/[email protected]/
>> Fixes: 1f265d2aea0d ("selftests/bpf: Remove not used headers")
>> Signed-off-by: Tiezhu Yang <[email protected]>
>
> not sure this should go through Arnaldo's tree instead,
> either way is fine with me

Agree, perf tree is better given the script is located there, so:

Acked-by: Daniel Borkmann <[email protected]>

2023-04-12 13:40:14

by Arnaldo Carvalho de Melo

[permalink] [raw]
Subject: Re: [PATCH bpf-next] tools headers: Remove s390 ptrace.h in check-headers.sh

Em Tue, Apr 11, 2023 at 07:35:02PM +0200, Daniel Borkmann escreveu:
> On 4/7/23 12:27 PM, Jiri Olsa wrote:
> > On Fri, Apr 07, 2023 at 10:21:30AM +0800, Tiezhu Yang wrote:
> > > After commit 1f265d2aea0d ("selftests/bpf: Remove not used headers"),
> > > tools/arch/s390/include/uapi/asm/ptrace.h has been removed, so remove
> > > it in check-headers.sh too, otherwise we can see the following build
> > > warning:
> > >
> > > diff: tools/arch/s390/include/uapi/asm/ptrace.h: No such file or directory
> > >
> > > Reported-by: kernel test robot <[email protected]>
> > > Link: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> > > Fixes: 1f265d2aea0d ("selftests/bpf: Remove not used headers")
> > > Signed-off-by: Tiezhu Yang <[email protected]>
> >
> > not sure this should go through Arnaldo's tree instead,
> > either way is fine with me
>
> Agree, perf tree is better given the script is located there, so:
>
> Acked-by: Daniel Borkmann <[email protected]>

Thanks, applied.

- Arnaldo