2020-02-18 19:22:12

by Christian Borntraeger

Subject: [PATCH] checkpatch: add NOKPROBE_SYMBOL to list of special cases

NOKPROBE_SYMBOL should - like EXPORT_SYMBOL - directly follow the
struct or union. This is widely used.
See git grep -B 1 NOKPROBE_SYMBOL

Signed-off-by: Christian Borntraeger <[email protected]>
---
scripts/checkpatch.pl | 1 +
1 file changed, 1 insertion(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index a63380c6b0d2..d4cc992d4876 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3354,6 +3354,7 @@ sub process {
$line =~ /^\+/ &&
!($line =~ /^\+\s*$/ ||
$line =~ /^\+\s*EXPORT_SYMBOL/ ||
+ $line =~ /^\+\s*NOKPROBE_SYMBOL/ ||
$line =~ /^\+\s*MODULE_/i ||
$line =~ /^\+\s*\#\s*(?:end|elif|else)/ ||
$line =~ /^\+[a-z_]*init/ ||
--
2.25.0

2020-02-25 08:52:48

by Christian Borntraeger

Subject: Re: [PATCH] checkpatch: add NOKPROBE_SYMBOL to list of special cases

On 18.02.20 20:21, Christian Borntraeger wrote:
> NOKPROBE_SYMBOL should - like EXPORT_SYMBOL - directly follow the
> struct or union. This is widely used.
> See git grep -B 1 NOKPROBE_SYMBOL
>
> Signed-off-by: Christian Borntraeger <[email protected]>
> ---
> scripts/checkpatch.pl | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index a63380c6b0d2..d4cc992d4876 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3354,6 +3354,7 @@ sub process {
> $line =~ /^\+/ &&
> !($line =~ /^\+\s*$/ ||
> $line =~ /^\+\s*EXPORT_SYMBOL/ ||
> + $line =~ /^\+\s*NOKPROBE_SYMBOL/ ||
> $line =~ /^\+\s*MODULE_/i ||
> $line =~ /^\+\s*\#\s*(?:end|elif|else)/ ||
> $line =~ /^\+[a-z_]*init/ ||
>


ping?

2020-03-11 07:30:10

by Christian Borntraeger

Subject: Re: [PATCH] checkpatch: add NOKPROBE_SYMBOL to list of special cases

On 25.02.20 09:35, Christian Borntraeger wrote:
> On 18.02.20 20:21, Christian Borntraeger wrote:
>> NOKPROBE_SYMBOL should - like EXPORT_SYMBOL - directly follow the
>> struct or union. This is widely used.
>> See git grep -B 1 NOKPROBE_SYMBOL
>>
>> Signed-off-by: Christian Borntraeger <[email protected]>
>> ---
>> scripts/checkpatch.pl | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>> index a63380c6b0d2..d4cc992d4876 100755
>> --- a/scripts/checkpatch.pl
>> +++ b/scripts/checkpatch.pl
>> @@ -3354,6 +3354,7 @@ sub process {
>> $line =~ /^\+/ &&
>> !($line =~ /^\+\s*$/ ||
>> $line =~ /^\+\s*EXPORT_SYMBOL/ ||
>> + $line =~ /^\+\s*NOKPROBE_SYMBOL/ ||
>> $line =~ /^\+\s*MODULE_/i ||
>> $line =~ /^\+\s*\#\s*(?:end|elif|else)/ ||
>> $line =~ /^\+[a-z_]*init/ ||
>>
>
>
> ping?

ping