2021-10-14 22:06:49

by Christophe JAILLET

Subject: [PATCH] mtip32xx: Remove redundant 'flush_workqueue()' calls

'destroy_workqueue()' already drains the queue before destroying it, so
there is no need to flush it explicitly.

Remove the redundant 'flush_workqueue()' calls.

This was generated with coccinelle:

@@
expression E;
@@
- flush_workqueue(E);
destroy_workqueue(E);

Signed-off-by: Christophe JAILLET <[email protected]>
---
drivers/block/mtip32xx/mtip32xx.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
index d0b40309f47e..c91b9010c1a6 100644
--- a/drivers/block/mtip32xx/mtip32xx.c
+++ b/drivers/block/mtip32xx/mtip32xx.c
@@ -4063,7 +4063,6 @@ static int mtip_pci_probe(struct pci_dev *pdev,

msi_initialize_err:
if (dd->isr_workq) {
- flush_workqueue(dd->isr_workq);
destroy_workqueue(dd->isr_workq);
drop_cpu(dd->work[0].cpu_binding);
drop_cpu(dd->work[1].cpu_binding);
@@ -4121,7 +4120,6 @@ static void mtip_pci_remove(struct pci_dev *pdev)
mtip_block_remove(dd);

if (dd->isr_workq) {
- flush_workqueue(dd->isr_workq);
destroy_workqueue(dd->isr_workq);
drop_cpu(dd->work[0].cpu_binding);
drop_cpu(dd->work[1].cpu_binding);
--
2.30.2

2021-10-18 03:27:19

by Christoph Hellwig

Subject: Re: [PATCH] mtip32xx: Remove redundant 'flush_workqueue()' calls

Looks good,

Reviewed-by: Christoph Hellwig <[email protected]>

2021-10-18 03:39:02

by Jens Axboe

Subject: Re: [PATCH] mtip32xx: Remove redundant 'flush_workqueue()' calls

On Thu, 14 Oct 2021 20:07:50 +0200, Christophe JAILLET wrote:
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
>
> Remove the redundant 'flush_workqueue()' calls.
>
> This was generated with coccinelle:
>
> [...]

Applied, thanks!

[1/1] mtip32xx: Remove redundant 'flush_workqueue()' calls
commit: 82c2ecfce69bb758faf81779e28e0ea1a342f1a7

Best regards,
--
Jens Axboe