2017-03-06 18:15:37

by Javier Martinez Canillas

[permalink] [raw]
Subject: Re: [PATCH] auxdisplay: img-ascii-lcd: add missing sentinel entry in img_ascii_lcd_matches

Hello Paul,

On 02/24/2017 06:56 PM, Paul Burton wrote:
> Hi Dmitry,
>
> On Monday, 20 February 2017 21:39:11 PST Dmitry Torokhov wrote:
>> The OF device table must be terminated, otherwise we'll be walking past
>> it and into areas unknown.
>>
>> This causes KASAN errors reported by 0day kernel testing robot.
>>
>> Reported-by: Fengguang Wu <[email protected]>
>> Tested-by: Fengguang Wu <[email protected]>
>> Fixes: 0cad855fbd08 ("auxdisplay: img-ascii-lcd: driver for simple
>> ASCII...") Cc: [email protected]
>> Signed-off-by: Dmitry Torokhov <[email protected]>
>
> An essentially identical patch was already submitted over here:
>
> https://patchwork.kernel.org/patch/9493973/
>
> I'm not sure how it ought to get into mainline - since the driver went through
> the MIPS tree perhaps this fix can too?
>

Do you know who should I ping about it? It has been posted a couple of months
ago.

> Thanks,
> Paul
>

Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America


2017-03-06 19:07:45

by Javier Martinez Canillas

[permalink] [raw]
Subject: Re: [PATCH] auxdisplay: img-ascii-lcd: add missing sentinel entry in img_ascii_lcd_matches

Hello Paul,

On 03/06/2017 03:54 PM, Paul Burton wrote:
> Hi Javier,
>
> On Monday, 6 March 2017 10:09:09 PST Javier Martinez Canillas wrote:
>> On 02/24/2017 06:56 PM, Paul Burton wrote:
>>> On Monday, 20 February 2017 21:39:11 PST Dmitry Torokhov wrote:
>>>> The OF device table must be terminated, otherwise we'll be walking past
>>>> it and into areas unknown.
>>>>
>>>> This causes KASAN errors reported by 0day kernel testing robot.
>>>>
>>>> Reported-by: Fengguang Wu <[email protected]>
>>>> Tested-by: Fengguang Wu <[email protected]>
>>>> Fixes: 0cad855fbd08 ("auxdisplay: img-ascii-lcd: driver for simple
>>>> ASCII...") Cc: [email protected]
>>>> Signed-off-by: Dmitry Torokhov <[email protected]>
>>>
>>> An essentially identical patch was already submitted over here:
>>>
>>> https://patchwork.kernel.org/patch/9493973/
>>>
>>> I'm not sure how it ought to get into mainline - since the driver went
>>> through the MIPS tree perhaps this fix can too?
>>
>> Do you know who should I ping about it? It has been posted a couple of
>> months ago.
>
> If it can go through the MIPS tree that would be Ralf (who I copied
> previously). If not then it's Miguel as auxdisplay maintainer.
>

Ok, Thanks for your help. I just asked in case MAINTAINERS wasn't up-to-date
since the patches were posted a long time ago and had no feedback.

> Thanks,
> Paul
>

Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America

2017-03-06 19:20:22

by Paul Burton

[permalink] [raw]
Subject: Re: [PATCH] auxdisplay: img-ascii-lcd: add missing sentinel entry in img_ascii_lcd_matches

Hi Javier,

On Monday, 6 March 2017 10:09:09 PST Javier Martinez Canillas wrote:
> On 02/24/2017 06:56 PM, Paul Burton wrote:
> > On Monday, 20 February 2017 21:39:11 PST Dmitry Torokhov wrote:
> >> The OF device table must be terminated, otherwise we'll be walking past
> >> it and into areas unknown.
> >>
> >> This causes KASAN errors reported by 0day kernel testing robot.
> >>
> >> Reported-by: Fengguang Wu <[email protected]>
> >> Tested-by: Fengguang Wu <[email protected]>
> >> Fixes: 0cad855fbd08 ("auxdisplay: img-ascii-lcd: driver for simple
> >> ASCII...") Cc: [email protected]
> >> Signed-off-by: Dmitry Torokhov <[email protected]>
> >
> > An essentially identical patch was already submitted over here:
> >
> > https://patchwork.kernel.org/patch/9493973/
> >
> > I'm not sure how it ought to get into mainline - since the driver went
> > through the MIPS tree perhaps this fix can too?
>
> Do you know who should I ping about it? It has been posted a couple of
> months ago.

If it can go through the MIPS tree that would be Ralf (who I copied
previously). If not then it's Miguel as auxdisplay maintainer.

Thanks,
Paul


Attachments:
signature.asc (833.00 B)
This is a digitally signed message part.

2017-03-06 19:49:06

by Dmitry Torokhov

[permalink] [raw]
Subject: Re: [PATCH] auxdisplay: img-ascii-lcd: add missing sentinel entry in img_ascii_lcd_matches

On Mon, Mar 06, 2017 at 03:58:04PM -0300, Javier Martinez Canillas wrote:
> Hello Paul,
>
> On 03/06/2017 03:54 PM, Paul Burton wrote:
> > Hi Javier,
> >
> > On Monday, 6 March 2017 10:09:09 PST Javier Martinez Canillas wrote:
> >> On 02/24/2017 06:56 PM, Paul Burton wrote:
> >>> On Monday, 20 February 2017 21:39:11 PST Dmitry Torokhov wrote:
> >>>> The OF device table must be terminated, otherwise we'll be walking past
> >>>> it and into areas unknown.
> >>>>
> >>>> This causes KASAN errors reported by 0day kernel testing robot.
> >>>>
> >>>> Reported-by: Fengguang Wu <[email protected]>
> >>>> Tested-by: Fengguang Wu <[email protected]>
> >>>> Fixes: 0cad855fbd08 ("auxdisplay: img-ascii-lcd: driver for simple
> >>>> ASCII...") Cc: [email protected]
> >>>> Signed-off-by: Dmitry Torokhov <[email protected]>
> >>>
> >>> An essentially identical patch was already submitted over here:
> >>>
> >>> https://patchwork.kernel.org/patch/9493973/
> >>>
> >>> I'm not sure how it ought to get into mainline - since the driver went
> >>> through the MIPS tree perhaps this fix can too?
> >>
> >> Do you know who should I ping about it? It has been posted a couple of
> >> months ago.
> >
> > If it can go through the MIPS tree that would be Ralf (who I copied
> > previously). If not then it's Miguel as auxdisplay maintainer.
> >
>
> Ok, Thanks for your help. I just asked in case MAINTAINERS wasn't up-to-date
> since the patches were posted a long time ago and had no feedback.

Maybe we could get akpm pick it up?

Thanks.

--
Dmitry

2017-03-07 12:46:47

by Javier Martinez Canillas

[permalink] [raw]
Subject: Re: [PATCH] auxdisplay: img-ascii-lcd: add missing sentinel entry in img_ascii_lcd_matches

Hello Dmitry,

On 03/06/2017 04:40 PM, Dmitry Torokhov wrote:
> On Mon, Mar 06, 2017 at 03:58:04PM -0300, Javier Martinez Canillas wrote:
>> Hello Paul,
>>
>> On 03/06/2017 03:54 PM, Paul Burton wrote:
>>> Hi Javier,
>>>
>>> On Monday, 6 March 2017 10:09:09 PST Javier Martinez Canillas wrote:
>>>> On 02/24/2017 06:56 PM, Paul Burton wrote:
>>>>> On Monday, 20 February 2017 21:39:11 PST Dmitry Torokhov wrote:
>>>>>> The OF device table must be terminated, otherwise we'll be walking past
>>>>>> it and into areas unknown.
>>>>>>
>>>>>> This causes KASAN errors reported by 0day kernel testing robot.
>>>>>>
>>>>>> Reported-by: Fengguang Wu <[email protected]>
>>>>>> Tested-by: Fengguang Wu <[email protected]>
>>>>>> Fixes: 0cad855fbd08 ("auxdisplay: img-ascii-lcd: driver for simple
>>>>>> ASCII...") Cc: [email protected]
>>>>>> Signed-off-by: Dmitry Torokhov <[email protected]>
>>>>>
>>>>> An essentially identical patch was already submitted over here:
>>>>>
>>>>> https://patchwork.kernel.org/patch/9493973/
>>>>>
>>>>> I'm not sure how it ought to get into mainline - since the driver went
>>>>> through the MIPS tree perhaps this fix can too?
>>>>
>>>> Do you know who should I ping about it? It has been posted a couple of
>>>> months ago.
>>>
>>> If it can go through the MIPS tree that would be Ralf (who I copied
>>> previously). If not then it's Miguel as auxdisplay maintainer.
>>>
>>
>> Ok, Thanks for your help. I just asked in case MAINTAINERS wasn't up-to-date
>> since the patches were posted a long time ago and had no feedback.
>
> Maybe we could get akpm pick it up?
>

Good idea, I'll re-send with akpm to cc so he can pick them.

> Thanks.
>

Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America