2014-06-03 18:30:10

by Stephen Boyd

Subject: [PATCH] unicore32: Remove ARCH_HAS_CPUFREQ config option

This config exists entirely to hide the cpufreq menu from the
kernel configuration unless a platform has selected it. Nothing
is actually built if this config is 'Y' and it just leads to more
patches that add a select under a platform Kconfig so that some
other CPUfreq option can be chosen. Let's remove the option so
that we can always enable CPUfreq drivers on unicore32 platforms.

Cc: Viresh Kumar <[email protected]>
Signed-off-by: Stephen Boyd <[email protected]>
---
arch/unicore32/Kconfig | 6 ------
1 file changed, 6 deletions(-)

diff --git a/arch/unicore32/Kconfig b/arch/unicore32/Kconfig
index aafad6fa1667..928237a7b9ca 100644
--- a/arch/unicore32/Kconfig
+++ b/arch/unicore32/Kconfig
@@ -51,9 +51,6 @@ config ARCH_HAS_ILOG2_U32
config ARCH_HAS_ILOG2_U64
bool

-config ARCH_HAS_CPUFREQ
- bool
-
config GENERIC_HWEIGHT
def_bool y

@@ -87,7 +84,6 @@ config ARCH_PUV3
select GENERIC_CLOCKEVENTS
select HAVE_CLK
select ARCH_REQUIRE_GPIOLIB
- select ARCH_HAS_CPUFREQ

# CONFIGs for ARCH_PUV3

@@ -198,9 +194,7 @@ menu "Power management options"

source "kernel/power/Kconfig"

-if ARCH_HAS_CPUFREQ
source "drivers/cpufreq/Kconfig"
-endif

config ARCH_SUSPEND_POSSIBLE
def_bool y if !ARCH_FPGA
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation

2014-06-04 05:10:33

by Viresh Kumar

Subject: Re: [PATCH] unicore32: Remove ARCH_HAS_CPUFREQ config option

On 4 June 2014 00:00, Stephen Boyd <[email protected]> wrote:
> This config exists entirely to hide the cpufreq menu from the
> kernel configuration unless a platform has selected it. Nothing
> is actually built if this config is 'Y' and it just leads to more
> patches that add a select under a platform Kconfig so that some
> other CPUfreq option can be chosen. Let's remove the option so
> that we can always enable CPUfreq drivers on unicore32 platforms.
>
> Cc: Viresh Kumar <[email protected]>
> Signed-off-by: Stephen Boyd <[email protected]>
> ---
> arch/unicore32/Kconfig | 6 ------
> 1 file changed, 6 deletions(-)

Reviewed-by: Viresh Kumar <[email protected]>

2014-06-05 00:34:32

by Guan Xuetao

Subject: 回复： [PATCH] unicore32: Remove ARCH_HAS_CPUFREQ config option

----- Stephen Boyd <[email protected]> 写道：
> This config exists entirely to hide the cpufreq menu from the
> kernel configuration unless a platform has selected it. Nothing
> is actually built if this config is 'Y' and it just leads to more
> patches that add a select under a platform Kconfig so that some
> other CPUfreq option can be chosen. Let's remove the option so
> that we can always enable CPUfreq drivers on unicore32 platforms.
>
> Cc: Viresh Kumar <[email protected]>
> Signed-off-by: Stephen Boyd <[email protected]>

Thanks, I'll push it in my repo.

Signed-off-by: Xuetao Guan <[email protected]>

> ---
> arch/unicore32/Kconfig | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/arch/unicore32/Kconfig b/arch/unicore32/Kconfig
> index aafad6fa1667..928237a7b9ca 100644
> --- a/arch/unicore32/Kconfig
> +++ b/arch/unicore32/Kconfig
> @@ -51,9 +51,6 @@ config ARCH_HAS_ILOG2_U32
> config ARCH_HAS_ILOG2_U64
> bool
>
> -config ARCH_HAS_CPUFREQ
> - bool
> -
> config GENERIC_HWEIGHT
> def_bool y
>
> @@ -87,7 +84,6 @@ config ARCH_PUV3
> select GENERIC_CLOCKEVENTS
> select HAVE_CLK
> select ARCH_REQUIRE_GPIOLIB
> - select ARCH_HAS_CPUFREQ
>
> # CONFIGs for ARCH_PUV3
>
> @@ -198,9 +194,7 @@ menu "Power management options"
>
> source "kernel/power/Kconfig"
>
> -if ARCH_HAS_CPUFREQ
> source "drivers/cpufreq/Kconfig"
> -endif
>
> config ARCH_SUSPEND_POSSIBLE
> def_bool y if !ARCH_FPGA
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> hosted by The Linux Foundation
>