2013-05-13 04:51:39

by Sachin Kamat

[permalink] [raw]
Subject: [PATCH 1/1] NVMe: Remove redundant version.h header include

version.h header inclusion is not necessary as detected by
checkversion.pl.

Signed-off-by: Sachin Kamat <[email protected]>
---
drivers/block/nvme-scsi.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/block/nvme-scsi.c b/drivers/block/nvme-scsi.c
index fed54b0..64bde68 100644
--- a/drivers/block/nvme-scsi.c
+++ b/drivers/block/nvme-scsi.c
@@ -44,7 +44,6 @@
#include <linux/sched.h>
#include <linux/slab.h>
#include <linux/types.h>
-#include <linux/version.h>
#include <scsi/sg.h>
#include <scsi/scsi.h>

--
1.7.9.5


2013-05-13 13:50:47

by Matthew Wilcox

[permalink] [raw]
Subject: RE: [PATCH 1/1] NVMe: Remove redundant version.h header include

I can't apply this patch. Instead of following what it says in MAINTAINERS, you've sent it to my Exchange address. And now it's all mangled.

NVM EXPRESS DRIVER
M: Matthew Wilcox <[email protected]>
L: [email protected]

________________________________________
From: Sachin Kamat [[email protected]]
Sent: May 12, 2013 9:38 PM
To: [email protected]
Cc: Wilcox, Matthew R; [email protected]; Busch, Keith; [email protected]
Subject: [PATCH 1/1] NVMe: Remove redundant version.h header include

version.h header inclusion is not necessary as detected by
checkversion.pl.

Signed-off-by: Sachin Kamat <[email protected]>
---
drivers/block/nvme-scsi.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/block/nvme-scsi.c b/drivers/block/nvme-scsi.c
index fed54b0..64bde68 100644
--- a/drivers/block/nvme-scsi.c
+++ b/drivers/block/nvme-scsi.c
@@ -44,7 +44,6 @@
#include <linux/sched.h>
#include <linux/slab.h>
#include <linux/types.h>
-#include <linux/version.h>
#include <scsi/sg.h>
#include <scsi/scsi.h>

--
1.7.9.5

2013-05-14 03:15:02

by Sachin Kamat

[permalink] [raw]
Subject: Re: [PATCH 1/1] NVMe: Remove redundant version.h header include

On 13 May 2013 19:20, Wilcox, Matthew R <[email protected]> wrote:
> I can't apply this patch. Instead of following what it says in MAINTAINERS, you've sent it to my Exchange address. And now it's all mangled.

I ran the get_maintainer.pl on the patch and this is what it gave me:

scripts/get_maintainer.pl
0001-NVMe-Remove-redundant-version.h-header-include.patch
Matthew Wilcox <[email protected]> (commit_signer:6/7=86%)
Vishal Verma <[email protected]> (commit_signer:5/7=71%)
Keith Busch <[email protected]> (commit_signer:3/7=43%)
Sachin Kamat <[email protected]> (commit_signer:1/7=14%)
[email protected] (open list)

I think with Dan's patch [1] it should provide the right info.
Resending this patch to the list pointed out by you.

[1] https://lkml.org/lkml/2013/5/13/302


>
> NVM EXPRESS DRIVER
> M: Matthew Wilcox <[email protected]>
> L: [email protected]

--
With warm regards,
Sachin