2002-04-24 03:34:13

by Steven Cole

[permalink] [raw]
Subject: [PATCH] 2.5.9-dj1, fix for make xconfig in drivers/isdn/Config.in

I read that some of you got this while doing make xconfig.

[steven@localhost linux-2.5.9-dj1]$ make xconfig
rm -f include/asm
( cd include ; ln -sf asm-i386 asm)
make -C scripts kconfig.tk
make[1]: Entering directory `/home/steven/kernels/linux-2.5.9-dj1/scripts'
cat header.tk >> ./kconfig.tk
./tkparse < ../arch/i386/config.in >> kconfig.tk
drivers/isdn/Config.in: 10: incorrect argument
make[1]: *** [kconfig.tk] Error 1
make[1]: Leaving directory `/home/steven/kernels/linux-2.5.9-dj1/scripts'
make: *** [xconfig] Error 2

This fix seems to be the obvious one.

Steven

--- linux-2.5.9-dj1/drivers/isdn/Config.in.orig Tue Apr 23 21:14:37 2002
+++ linux-2.5.9-dj1/drivers/isdn/Config.in Tue Apr 23 21:22:10 2002
@@ -7,7 +7,7 @@
if [ "$CONFIG_NET" != "n" ]; then
bool 'ISDN support' CONFIG_ISDN_BOOL

- if [ "$CONFIG_ISDN_BOOL" == "y" ]; then
+ if [ "$CONFIG_ISDN_BOOL" = "y" ]; then
mainmenu_option next_comment
comment 'Old ISDN4Linux'





2002-04-25 09:18:04

by A Guy Called Tyketto

[permalink] [raw]
Subject: Re: [PATCH] 2.5.9-dj1, fix for make xconfig in drivers/isdn/Config.in

On Tue, Apr 23, 2002 at 09:31:59PM -0600, Steven Cole wrote:
> I read that some of you got this while doing make xconfig.
>
> [steven@localhost linux-2.5.9-dj1]$ make xconfig
> rm -f include/asm
> ( cd include ; ln -sf asm-i386 asm)
> make -C scripts kconfig.tk
> make[1]: Entering directory `/home/steven/kernels/linux-2.5.9-dj1/scripts'
> cat header.tk >> ./kconfig.tk
> ./tkparse < ../arch/i386/config.in >> kconfig.tk
> drivers/isdn/Config.in: 10: incorrect argument
> make[1]: *** [kconfig.tk] Error 1
> make[1]: Leaving directory `/home/steven/kernels/linux-2.5.9-dj1/scripts'
> make: *** [xconfig] Error 2
>
> This fix seems to be the obvious one.

This is definitely the right fix, now that I compare what I threw to
the list earlier, to the other Config.in scripts in the tree. Plus, this
applies to a vanilla 2.5.10.

Linus, Dave, please consider applying.

BL.
--
Brad Littlejohn | Email: [email protected]
Unix Systems Administrator, | [email protected]
Web + NewsMaster, BOFH.. Smeghead! :) | http://www.wizard.com/~tyketto
PGP: 1024D/E319F0BF 6980 AAD6 7329 E9E6 D569 F620 C819 199A E319 F0BF