2002-10-09 18:17:05

by Paul Larson

[permalink] [raw]
Subject: [PATCH] Possible null pointer in drivers/serial/core.c

In core.c:uart_startup() line 210 I found a possible null pointer
dereference at line 210:
if (info->tty->termios->c_cflag & CBAUD)

There are other things around that same area that do the checking for
info->tty before dereferencing it, so either they are unneeded, or this
one needs a check too.

Thanks,
Paul Larson
--------------------
--- linux-2.5/drivers/serial/core.c Wed Oct 9 13:45:11 2002
+++ linux-corefix/drivers/serial/core.c Wed Oct 9 13:50:09 2002
@@ -207,7 +207,7 @@
* Setup the RTS and DTR signals once the
* port is open and ready to respond.
*/
- if (info->tty->termios->c_cflag & CBAUD)
+ if (info->tty && (info->tty->termios->c_cflag & CBAUD))
uart_set_mctrl(port, TIOCM_RTS | TIOCM_DTR);
}