2002-12-21 04:17:39

by Scorpion

[permalink] [raw]
Subject: USB/Storage - transport.c - Olympus D150Zoom



Hi,
I was trying to put my digital camera Olympus Brio Zoom D-150Zoom
to work on my RedHat 7.3 (2.4.18-3, redhat) when found this web page:
http://www.gingerbear.org/~esm/olympus/

Clicking on transport.c.diff link and taking a look into
/usr/src/linux-2.4.18-3/drivers/usb/storage/transport.c file
I started to ask my self what is doing the
if (bcs.Signature != cpu_to_le32(US_BULK_CS_SIGN) ||
statement there? Please if anyone could, answer me...
The patch applied to "support" this camera just remove this comparison,
so what it does?

Best regards,
Scorpion.
---------------transport.c.diff----------------
--- drivers/usb/storage/transport.c 2002/08/07 13:14:59 1.1
+++ drivers/usb/storage/transport.c 2002/08/07 13:15:08
@@ -1197,8 +1197,7 @@
US_DEBUGP("Bulk status Sig 0x%x T 0x%x R %d Stat 0x%x\n",
le32_to_cpu(bcs.Signature), bcs.Tag,
bcs.Residue, bcs.Status);
- if (bcs.Signature != cpu_to_le32(US_BULK_CS_SIGN) ||
- bcs.Tag != bcb.Tag ||
+ if (bcs.Tag != bcb.Tag ||
bcs.Status > US_BULK_STAT_PHASE || partial != 13) {
US_DEBUGP("Bulk logical error\n");
return USB_STOR_TRANSPORT_ERROR;
---------------transport.c.diff----------------