2013-09-17 21:26:45

by Dave Jones

Subject: nouveau: remove pointless assignment

self-assignment of a variable doesn't make a lot of sense.

Signed-off-by: Dave Jones <[email protected]>

diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c
index 755c38d..d0a737c 100644
--- a/drivers/gpu/drm/nouveau/nouveau_bo.c
+++ b/drivers/gpu/drm/nouveau/nouveau_bo.c
@@ -982,7 +982,7 @@ nouveau_bo_move_m2mf(struct ttm_buffer_object *bo, int evict, bool intr,
bool no_wait_gpu, struct ttm_mem_reg *new_mem)
{
struct nouveau_drm *drm = nouveau_bdev(bo->bdev);
- struct nouveau_channel *chan = chan = drm->ttm.chan;
+ struct nouveau_channel *chan = drm->ttm.chan;
struct nouveau_bo *nvbo = nouveau_bo(bo);
struct ttm_mem_reg *old_mem = &bo->mem;
int ret;

2013-09-19 01:10:18

by Ben Skeggs

Subject: Re: nouveau: remove pointless assignment

----- Original Message -----
> From: "Dave Jones" <[email protected]>
> To: "Linux Kernel" <[email protected]>
> Cc: [email protected], [email protected]
> Sent: Wednesday, 18 September, 2013 7:26:34 AM
> Subject: nouveau: remove pointless assignment
>
> self-assignment of a variable doesn't make a lot of sense.
Thanks, search-and-replace left-over, pulled into my tree.

Ben.

>
> Signed-off-by: Dave Jones <[email protected]>
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c
> b/drivers/gpu/drm/nouveau/nouveau_bo.c
> index 755c38d..d0a737c 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_bo.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c
> @@ -982,7 +982,7 @@ nouveau_bo_move_m2mf(struct ttm_buffer_object *bo, int
> evict, bool intr,
> bool no_wait_gpu, struct ttm_mem_reg *new_mem)
> {
> struct nouveau_drm *drm = nouveau_bdev(bo->bdev);
> - struct nouveau_channel *chan = chan = drm->ttm.chan;
> + struct nouveau_channel *chan = drm->ttm.chan;
> struct nouveau_bo *nvbo = nouveau_bo(bo);
> struct ttm_mem_reg *old_mem = &bo->mem;
> int ret;
>