2003-02-17 22:40:05

by Stephen Hemminger

Subject: [PATCH] Fix warnings for XFS on 2.5.61

This patch gets rid of the following warnings.

fs/xfs/support/qsort.c: In function `qsort':
fs/xfs/support/qsort.c:202: warning: duplicate `const'

diff -Nru a/fs/xfs/support/qsort.c b/fs/xfs/support/qsort.c
--- a/fs/xfs/support/qsort.c Mon Feb 17 14:16:15 2003
+++ b/fs/xfs/support/qsort.c Mon Feb 17 14:16:15 2003
@@ -199,7 +199,7 @@
{
char *const end_ptr = &base_ptr[size * (total_elems - 1)];
char *tmp_ptr = base_ptr;
- char *thresh = min(end_ptr, base_ptr + max_thresh);
+ char *const thresh = min_t(char *const, end_ptr, base_ptr + max_thresh);
register char *run_ptr;

/* Find smallest element in first threshold and place it at the

2003-02-18 00:48:15

by Christoph Hellwig

Subject: Re: [PATCH] Fix warnings for XFS on 2.5.61

On Mon, Feb 17, 2003 at 02:49:57PM -0800, Stephen Hemminger wrote:
> This patch gets rid of the following warnings.
>
> fs/xfs/support/qsort.c: In function `qsort':
> fs/xfs/support/qsort.c:202: warning: duplicate `const'

This is a bug in recent gcc versions, submit a patch to gcc instead.