2003-02-18 19:13:42

by Stephen Hemminger

[permalink] [raw]
Subject: CIFS (2.5.62) build problems

CIFS can not be built as a module because it cifs_readpages calls:
__pagevec_lru_add
add_to_page_cache

The patch to mm/filemap.c and mm/swap.c is trivial, the question is
should those internal functions be exported in the first place.

--
Stephen Hemminger <[email protected]>
Open Source Devlopment Lab


2003-02-18 19:27:16

by Andrew Morton

[permalink] [raw]
Subject: Re: CIFS (2.5.62) build problems

Stephen Hemminger <[email protected]> wrote:
>
> CIFS can not be built as a module because it cifs_readpages calls:
> __pagevec_lru_add
> add_to_page_cache
>
> The patch to mm/filemap.c and mm/swap.c is trivial, the question is
> should those internal functions be exported in the first place.
>

Yes they need to be exported. Otherwise filesystems cannot implement
a fully custom readpages address_space op.

I have a fix for this queued.