2003-03-27 02:18:57

by Nigel Cunningham

[permalink] [raw]
Subject: Annouce: Initial SWSUSP 2.4 port to 2.5 available.

Hi all.

It is with delight that I write to announce the first release of the
port of Software Suspend for 2.4 to 2.5. This version has all the
functionality of the 2.4 version beta19-17 - the current development
version for 2.4. This includes the following enhancements over the
version currently included in the 2.5 kernel:

- HighMem support
- Multiple swap partiton support
- Ability to cancel a suspend by pressing ALT.
- Ability to save what is close a perfect image image of RAM (resulting
in a very fast, responsive system on resume - assumes enough swap
available to store your full image)
- Extensive debugging capabilities
- Fast and reliable (extensive testing done under 2.4).

There are issues still to be dealt with, but these should not in any way
interfere with testing at this stage. They are:

- 2 page flags currently used: to be converted to dynamically allocated
bitmaps
- Interaction with S3 support to be tested and worked on (some common
files affected, S3 support not tested).
- Code cleanups still to be done in some places.

You can find the patch against 2.5.66 on
http://www.sourceforge.net/projects/swsusp. It's in the swsusp-devel section at
the bottom of the list.

Regards,

Nigel


--
Nigel Cunningham
495 St Georges Road South, Hastings 4201, New Zealand

Be diligent to present yourself approved to God as a workman who does
not need to be ashamed, handling accurately the word of truth.
-- 2 Timothy 2:14, NASB.


2003-03-27 17:52:43

by Patrick Mochel

[permalink] [raw]
Subject: Re: Annouce: Initial SWSUSP 2.4 port to 2.5 available.


Hi there.

> - HighMem support
> - Multiple swap partiton support
> - Ability to cancel a suspend by pressing ALT.
> - Ability to save what is close a perfect image image of RAM (resulting
> in a very fast, responsive system on resume - assumes enough swap
> available to store your full image)
> - Extensive debugging capabilities
> - Fast and reliable (extensive testing done under 2.4).

I'm glad that you have done this work, and I look forward to merging it
with the power management infrastructure work I have been doing. However,
there are several outstanding issues.

> There are issues still to be dealt with, but these should not in any way
> interfere with testing at this stage. They are:
>
> - 2 page flags currently used: to be converted to dynamically allocated
> bitmaps

I will not take the code which still relies on the page flag bits. I look
forward to your dynamic bitmap implementation.

As for the current patch, I was unable to test its actual functionality,
which I will get to in a moment.

First, I request that you please name the patches something sensible that
won't collide with anything else, like swsusp-2.5.66-<n>.diff, not
'patch-2.5.66-<n>.diff'.

Also, please make it explicitly clear which patch(es) are needed for
download. On the sourceforge site, both -01 and -02 are highlighted as
current, though they appear to different versions of the same thing.

I'm glad to hear that you have completed the full port, but many people
appreciate incremental patches, especially if the cumulative changes
touch multiple parts of the kernel. Please consider breaking the one large
patch into multiple, easily digestible, chunks.

Finally, with either patch, there are unresolved symbols:

arch/i386/kernel/built-in.o: In function `do_suspend_lowlevel':
arch/i386/kernel/built-in.o(.data+0x1644): undefined reference to `save_processor_state'
arch/i386/kernel/built-in.o(.data+0x164a): undefined reference to `saved_context_esp'
arch/i386/kernel/built-in.o(.data+0x164f): undefined reference to `saved_context_eax'
arch/i386/kernel/built-in.o(.data+0x1655): undefined reference to `saved_context_ebx'
arch/i386/kernel/built-in.o(.data+0x165b): undefined reference to `saved_context_ecx'
arch/i386/kernel/built-in.o(.data+0x1661): undefined reference to `saved_context_edx'
arch/i386/kernel/built-in.o(.data+0x1667): undefined reference to `saved_context_ebp'
arch/i386/kernel/built-in.o(.data+0x166d): undefined reference to `saved_context_esi'
arch/i386/kernel/built-in.o(.data+0x1673): undefined reference to `saved_context_edi'
arch/i386/kernel/built-in.o(.data+0x167a): undefined reference to `saved_context_eflags'

The fix is likely trivial, but it is annoying that it happens in the first
place.

Thanks,


-pat

2003-03-28 11:24:38

by Pavel Machek

[permalink] [raw]
Subject: Re: Annouce: Initial SWSUSP 2.4 port to 2.5 available.

Hi!

> I'm glad to hear that you have completed the full port, but many people
> appreciate incremental patches, especially if the cumulative changes
> touch multiple parts of the kernel. Please consider breaking the one large
> patch into multiple, easily digestible, chunks.
>
> Finally, with either patch, there are unresolved symbols:
>
> arch/i386/kernel/built-in.o: In function `do_suspend_lowlevel':
> arch/i386/kernel/built-in.o(.data+0x1644): undefined reference to `save_processor_state'
> arch/i386/kernel/built-in.o(.data+0x164a): undefined reference to `saved_context_esp'
> arch/i386/kernel/built-in.o(.data+0x164f): undefined reference to `saved_context_eax'
> arch/i386/kernel/built-in.o(.data+0x1655): undefined reference to `saved_context_ebx'
> arch/i386/kernel/built-in.o(.data+0x165b): undefined reference to `saved_context_ecx'
> arch/i386/kernel/built-in.o(.data+0x1661): undefined reference to `saved_context_edx'
> arch/i386/kernel/built-in.o(.data+0x1667): undefined reference to `saved_context_ebp'
> arch/i386/kernel/built-in.o(.data+0x166d): undefined reference to `saved_context_esi'
> arch/i386/kernel/built-in.o(.data+0x1673): undefined reference to `saved_context_edi'
> arch/i386/kernel/built-in.o(.data+0x167a): undefined reference to `saved_context_eflags'
>
> The fix is likely trivial, but it is annoying that it happens in the first
> place.

Thats S3 support. Likely Nigel has not S3 compiled in and you
have. Disalbe CONFIG_ACPI_SLEEP as a workaround.
Pavel
--
Horseback riding is like software...
...vgf orggre jura vgf serr.

2003-03-28 15:44:56

by Patrick Mochel

[permalink] [raw]
Subject: Re: Annouce: Initial SWSUSP 2.4 port to 2.5 available.


On Fri, 28 Mar 2003, Pavel Machek wrote:

> Hi!
>
> > I'm glad to hear that you have completed the full port, but many people
> > appreciate incremental patches, especially if the cumulative changes
> > touch multiple parts of the kernel. Please consider breaking the one large
> > patch into multiple, easily digestible, chunks.
> >
> > Finally, with either patch, there are unresolved symbols:
> >
> > arch/i386/kernel/built-in.o: In function `do_suspend_lowlevel':
> > arch/i386/kernel/built-in.o(.data+0x1644): undefined reference to `save_processor_state'
> > arch/i386/kernel/built-in.o(.data+0x164a): undefined reference to `saved_context_esp'
> > arch/i386/kernel/built-in.o(.data+0x164f): undefined reference to `saved_context_eax'
> > arch/i386/kernel/built-in.o(.data+0x1655): undefined reference to `saved_context_ebx'
> > arch/i386/kernel/built-in.o(.data+0x165b): undefined reference to `saved_context_ecx'
> > arch/i386/kernel/built-in.o(.data+0x1661): undefined reference to `saved_context_edx'
> > arch/i386/kernel/built-in.o(.data+0x1667): undefined reference to `saved_context_ebp'
> > arch/i386/kernel/built-in.o(.data+0x166d): undefined reference to `saved_context_esi'
> > arch/i386/kernel/built-in.o(.data+0x1673): undefined reference to `saved_context_edi'
> > arch/i386/kernel/built-in.o(.data+0x167a): undefined reference to `saved_context_eflags'
> >
> > The fix is likely trivial, but it is annoying that it happens in the first
> > place.
>
> Thats S3 support. Likely Nigel has not S3 compiled in and you
> have. Disalbe CONFIG_ACPI_SLEEP as a workaround.

That works.

Thanks,


-pat