2021-04-23 01:54:28

by Xiaochuan Mao

Subject: [PATCH] MIPS:DTS:Fix label name and interrupt number of ohci for Loongson-2K

from Loongson-2K1000 user manual know that under pci bus
the device num is 4, function number is 2 and register is 0x2200
is ohci. the ohci interrupt number is 51. because Loongson-2K1000 has
64 interrupt sources, 0-31 correspond to the device tree liointc0 device
node, and the other correspond to liointc1 node. so it should be
number 19 correspon to liointc1.

Signed-off-by: xiaochuan mao <[email protected]>
---
arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
index fd0e99bfe57b..89f079097f32 100644
--- a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
+++ b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
@@ -125,14 +125,14 @@
interrupt-parent = <&liointc1>;
};

- ehci@4,2 {
+ ohci@4,2 {
compatible = "pci0014,7a24.0",
"pci0014,7a24",
"pciclass0c0310",
"pciclass0c03";

reg = <0x2200 0x0 0x0 0x0 0x0>;
- interrupts = <17 IRQ_TYPE_LEVEL_LOW>;
+ interrupts = <19 IRQ_TYPE_LEVEL_LOW>;
interrupt-parent = <&liointc1>;
};

--
2.17.1

2021-04-23 02:38:23

by Qing Zhang

Subject: Re: [PATCH] MIPS:DTS:Fix label name and interrupt number of ohci for Loongson-2K

On 04/23/2021 09:52 AM, xiaochuan mao wrote:
> from Loongson-2K1000 user manual know that under pci bus
> the device num is 4, function number is 2 and register is 0x2200
> is ohci. the ohci interrupt number is 51. because Loongson-2K1000 has
> 64 interrupt sources, 0-31 correspond to the device tree liointc0 device
> node, and the other correspond to liointc1 node. so it should be
> number 19 correspon to liointc1.
>
> Signed-off-by: xiaochuan mao <[email protected]>
>
Hi, xiaozhuan


Thanks for the patch, this is my mistake.

Can you correct the GPL-3.0 of this file to GPL-2.0 by the way?

Thanks

-Qing

2021-04-23 12:24:28

by Thomas Bogendoerfer

Subject: Re: [PATCH] MIPS:DTS:Fix label name and interrupt number of ohci for Loongson-2K

On Fri, Apr 23, 2021 at 09:52:34AM +0800, xiaochuan mao wrote:
> from Loongson-2K1000 user manual know that under pci bus
> the device num is 4, function number is 2 and register is 0x2200
> is ohci. the ohci interrupt number is 51. because Loongson-2K1000 has
> 64 interrupt sources, 0-31 correspond to the device tree liointc0 device
> node, and the other correspond to liointc1 node. so it should be
> number 19 correspon to liointc1.
>
> Signed-off-by: xiaochuan mao <[email protected]>
> ---
> arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

applied to mips-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]