2003-06-07 17:18:13

by Martin Schlemmer

[permalink] [raw]
Subject: [PATCH][2.5] compile fixes for recent changes to include/net/sock.h

Hi

This fixes compile failures due to recent changes in include/net/sock.h.
Seems like a lot of struct sock's members had a 'sk_' appended, but
changes to following was missed:

drivers/net/ethertap.c
fs/smbfs/sock.c
fs/smbfs/proc.c

If any queries, please also CC me at <fgs at lantic.net>, as current
mail offline until monday.


Regards,

--

Martin Schlemmer




Attachments:
linux-2.5.70-bk12-sock-fixes.patch (3.76 kB)
signature.asc (189.00 B)
This is a digitally signed message part
Download all attachments

2003-06-07 20:48:51

by Arnaldo Carvalho de Melo

[permalink] [raw]
Subject: Re: [PATCH][2.5] compile fixes for recent changes to include/net/sock.h

Em Sat, Jun 07, 2003 at 07:30:25PM +0200, Martin Schlemmer escreveu:
> Hi
>
> This fixes compile failures due to recent changes in include/net/sock.h.
> Seems like a lot of struct sock's members had a 'sk_' appended, but
> changes to following was missed:
>
> drivers/net/ethertap.c
> fs/smbfs/sock.c
> fs/smbfs/proc.c

Thanks a lot, the smbfs one was already merged by Linus, somebody submitted
it some hours ago, the ethertap I'll push to DaveM today.

Question: it is marked as OBSOLETE, should we ditch it now?

- Arnaldo

2003-06-08 09:00:44

by David Miller

[permalink] [raw]
Subject: Re: [PATCH][2.5] compile fixes for recent changes to include/net/sock.h

From: Arnaldo Carvalho de Melo <[email protected]>
Date: Sat, 7 Jun 2003 18:03:38 -0300

Question: it is marked as OBSOLETE, should we ditch it now?

Unfortunately I have no idea how widely used ethertap is these
days, and more importantly if most people have switched over
to tun/tap for those kinds of applications.

2003-06-08 15:19:52

by Arnaldo Carvalho de Melo

[permalink] [raw]
Subject: Re: [PATCH][2.5] compile fixes for recent changes to include/net/sock.h

Em Sun, Jun 08, 2003 at 02:11:29AM -0700, David S. Miller escreveu:
> From: Arnaldo Carvalho de Melo <[email protected]>
> Date: Sat, 7 Jun 2003 18:03:38 -0300
>
> Question: it is marked as OBSOLETE, should we ditch it now?
>
> Unfortunately I have no idea how widely used ethertap is these
> days, and more importantly if most people have switched over
> to tun/tap for those kinds of applications.

I see, ok, it is already marked OBSOLETE, so we can ditch it in 2.8/3.0.

- Arnaldo

2003-06-09 18:43:24

by Riley Williams

[permalink] [raw]
Subject: RE: [PATCH][2.5] compile fixes for recent changes to include/net/sock.h

Hi David.

> Unfortunately I have no idea how widely used ethertap is these
> days, and more importantly if most people have switched over
> to tun/tap for those kinds of applications.

Red Hat 9 includes at least one application that still uses ethertap
as I received an error message suggesting that I set up an ethertap
device when running it about a fortnight ago. Unfortunately, I don't
remember which app it was, sorry...

Best wishes from Riley.
---
* Nothing as pretty as a smile, nothing as ugly as a frown.

---
Outgoing mail is certified Virus Free.
Checked by AVG anti-virus system (http://www.grisoft.com).
Version: 6.0.488 / Virus Database: 287 - Release Date: 5-Jun-2003