LinuxLists.cc - [PATCH] 2.[45] eexpress.c skb

2003-06-18 22:14:55

Subject: [PATCH] 2.[45] eexpress.c skb_padto fixes broke pppoe

Hi,

I posted this to linux-net and didn't get a reply so I am posting it
here. Please cc any replies.

The attached patch fixes the breakage caused by the recent skb_padto
security fixes. It applies to both 2.4.21 and 2.5.72 (with a little
fuzz). I have tested it on 2.4.21 but not on 2.5.

If it looks ok can it be included in 2.4 and 2.5?

Regards,

Shane

Attachments:

eexpress_skb_padto_fix.diff (614.00 B)

2003-06-21 12:34:15

by Alan

[permalink] [raw]

Subject: Re: [PATCH] 2.[45] eexpress.c skb_padto fixes broke pppoe

On Mer, 2003-06-18 at 23:28, Shane Shrybman wrote:
> Hi,
>
> I posted this to linux-net and didn't get a reply so I am posting it
> here. Please cc any replies.

Cleaner is to set buf->len = ETH_ZLEN for the padto path IMHO, that
keeps the old horrible length compute stuff dead

2003-06-22 14:06:06

by Shane Shrybman

[permalink] [raw]

Subject: Re: [PATCH] 2.[45] eexpress.c skb_padto fixes broke pppoe

Hi,

On Sat, 2003-06-21 at 08:46, Alan Cox wrote:
[..SNIP..]
>
> Cleaner is to set buf->len = ETH_ZLEN for the padto path IMHO, that
> keeps the old horrible length compute stuff dead
>

Attached is a better patch that also removes a duplicate comment. I have
tested it on 2.4 but it applies to 2.5 as well (with offset).

Regards,

Shane

Attachments:

eexpress_skb_padto_fix3.diff (647.00 B)