2003-07-07 15:47:42

by Disconnect

[permalink] [raw]

Subject: [2.4][TRIVIAL] Use of uninitialized vars in arch/i386/kernel/process.c

---

# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
# ChangeSet 1.1042 -> 1.1043
# arch/i386/kernel/process.c 1.14 -> 1.15
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 03/07/07 dis@slappy.(none) 1.1043
# Initialize reboot_mode to defaults (according to comments) even if reboot= is lacking. Ditto for reboot_thru_bios.
# (Warm boot, use bios.)
# --------------------------------------------
#
diff -Nru a/arch/i386/kernel/process.c b/arch/i386/kernel/process.c
--- a/arch/i386/kernel/process.c Mon Jul 7 11:42:50 2003
+++ b/arch/i386/kernel/process.c Mon Jul 7 11:42:50 2003
@@ -152,8 +152,8 @@
__setup("idle=", idle_setup);

static long no_idt[2];
-static int reboot_mode;
-int reboot_thru_bios;
+static int reboot_mode=0x1234;
+int reboot_thru_bios=1;

#ifdef CONFIG_SMP
int reboot_smp = 0;

---

Attachments:

process.c.diff (1.02 kB)

2003-07-09 11:50:31

by Alan

[permalink] [raw]

Subject: Re: [2.4][TRIVIAL] Use of uninitialized vars in arch/i386/kernel/process.c

---

On Llu, 2003-07-07 at 17:01, Disconnect wrote:
> If you don't pass reboot=, reboot_mode and reboot_thru_bios are used
> uninitialized and (in the case of reboot_mode) written directly to
> memory for the bios.

reboot_mode is static so defaults to zero.