2003-08-29 14:55:12

by Geert Uytterhoeven

[permalink] [raw]
Subject: [PATCH] M68k invalid vs. illegal

M68k: Use `invalid' instead of `illegal' (from Steven Cole in 2.5.x)

--- linux-2.4.23-pre1/arch/m68k/apollo/dn_ints.c Tue Jun 4 15:23:04 2002
+++ linux-m68k-2.4.23-pre1/arch/m68k/apollo/dn_ints.c Mon Jul 21 20:39:55 2003
@@ -43,7 +43,7 @@
int dn_request_irq(unsigned int irq, void (*handler)(int, void *, struct pt_regs *), unsigned long flags, const char *devname, void *dev_id) {

if((irq<0) || (irq>15)) {
- printk("Trying to request illegal IRQ\n");
+ printk("Trying to request invalid IRQ\n");
return -ENXIO;
}

@@ -69,7 +69,7 @@
void dn_free_irq(unsigned int irq, void *dev_id) {

if((irq<0) || (irq>15)) {
- printk("Trying to free illegal IRQ\n");
+ printk("Trying to free invalid IRQ\n");
return ;
}

--- linux-2.4.23-pre1/arch/m68k/q40/q40ints.c Thu Mar 13 07:43:37 2003
+++ linux-m68k-2.4.23-pre1/arch/m68k/q40/q40ints.c Mon Jul 21 20:39:55 2003
@@ -168,7 +168,7 @@
{
case 1: case 2: case 8: case 9:
case 12: case 13:
- printk("%s: ISA IRQ %d from %x illegal\n", __FUNCTION__, irq, (unsigned)dev_id);
+ printk("%s: ISA IRQ %d from %x invalid\n", __FUNCTION__, irq, (unsigned)dev_id);
return;
case 11: irq=10;
default:

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds


2003-08-29 15:19:31

by Steven Cole

[permalink] [raw]
Subject: Re: [PATCH] M68k invalid vs. illegal

On Fri, 2003-08-29 at 08:51, Geert Uytterhoeven wrote:
> M68k: Use `invalid' instead of `illegal' (from Steven Cole in 2.5.x)
>

For the record, the original idea for these changes should be credited
to Richard B. Johnson via this post:
http://marc.theaimsgroup.com/?l=linux-kernel&m=105278255404767&w=2

Alan verified that Richard was right, and all I did was the grunt work.

Steven