2003-09-29 03:08:51

by Ramón Rey Vicente

[permalink] [raw]
Subject: [patch][2.6.0-test6] ALSA pci Kconfig polishes

Hi.

I think the ALSA pci devices must select the GAMEPORT option
automatically instead of depends on GAMEPORT.

The GAMEPORT is a feature of the device, is not a requisite.
--
Ram?n Rey Vicente <ramon dot rey at hispalinux dot es>
jabber ID <rreylinux at jabber dot org>
GPG public key ID 0xBEBD71D5 -> http://pgp.escomposlinux.org/



Attachments:
alsa_pci_select_gameport.diff (1.91 kB)
signature.asc (189.00 B)
Esta parte del mensaje est? firmada digitalmente
Download all attachments

2003-09-29 06:09:38

by Muli Ben-Yehuda

[permalink] [raw]
Subject: Re: [patch][2.6.0-test6] ALSA pci Kconfig polishes

On Mon, Sep 29, 2003 at 05:08:45AM +0200, Ram?n Rey Vicente wrote:
> Hi.
>
> I think the ALSA pci devices must select the GAMEPORT option
> automatically instead of depends on GAMEPORT.
>
> The GAMEPORT is a feature of the device, is not a requisite.

This patch makes GAMEPORT required, while actually it's only required
to not be a module if the sound driver is builtin. See my earlier mail
on the subject for the details:
http://marc.theaimsgroup.com/?l=linux-kernel&m=106479206731633&w=2

A better fix would be to revert the change in sound/pci/Kconfig from
CONFIG_SOUND_GAMEPORT to CONFIG_GAMEPORT back to
CONFIG_SOUND_GAMEPORT, or just drop this dependency for ALSA and let
the #ifdefs in the code take care of it. Forcing the gameport to be
compiled in when it's not necessary is bloat, IMHO.
--
Muli Ben-Yehuda
http://www.mulix.org


Attachments:
(No filename) (846.00 B)
signature.asc (189.00 B)
Digital signature
Download all attachments