2003-11-14 04:19:01

by Joseph D. Wagner

[permalink] [raw]
Subject: Adding Deprecated Attribute Tags

I formally request that the struct ext2_dir_entry and ext3_dir_entry in the
ext2_fs.h and ext3_fs.h files be changed to add the below specified
attributes:

struct ext2_dir_entry {
__u32 inode; /* Inode number */
__u16 rec_len; /* Directory entry length */
__u16 name_len; /* Name length */
char name[EXT2_NAME_LEN]; /* File name */
} __attribute__ ((deprecated));

struct ext3_dir_entry {
__u32 inode; /* Inode number */
__u16 rec_len; /* Directory entry length */
__u16 name_len; /* Name length */
char name[EXT3_NAME_LEN]; /* File name */
} __attribute__ ((deprecated));

This will aid future development and debugging to ensure that everyone uses
the new struct ext2_dir_entry_2 and can take advantage of the additional
fields.

Joseph D. Wagner


2003-11-14 18:01:45

by Robert Love

[permalink] [raw]
Subject: Re: Adding Deprecated Attribute Tags

On Thu, 2003-11-13 at 11:18, Joseph D. Wagner wrote:

> This will aid future development and debugging to ensure that everyone uses
> the new struct ext2_dir_entry_2 and can take advantage of the additional
> fields.

We have a special __deprecated define in include/compiler.h and family
to safely mark this (e.g., it defines away on older gcc's and Intel's
CC).

Robert Love