2004-01-12 10:03:47

by Bastien Nocera

[permalink] [raw]
Subject: uk keyboard broken by input updates?

Hello,

2.6.1 broke the ~/# key on my UK keyboard, when it used to work fine on
2.6.0. The key is now acting as Print Screen/SysRq. The keyboard is
connected as PS/2 (though it is also plugged as USB, it's a Logitech
wireless keyboard, with the receiver being the same for the mouse and
keyboard).

I didn't look at the changes made to the input layer in details. Could
anyone shed some light on this problem?

Cheers

---
Bastien Nocera <[email protected]>
Her voice had that tense, grating quality, like a first-generation
thermal paper fax machine that needed a band tightened.


2004-01-12 10:21:17

by Kieran

[permalink] [raw]
Subject: Re: uk keyboard broken by input updates?

I have exactly the same problem using 2.6.1 and an IBM USB keyboard, not
really had a chance to look into it yet though.

> Hello,
>
> 2.6.1 broke the ~/# key on my UK keyboard, when it used to work fine on
> 2.6.0. The key is now acting as Print Screen/SysRq. The keyboard is
> connected as PS/2 (though it is also plugged as USB, it's a Logitech
> wireless keyboard, with the receiver being the same for the mouse and
> keyboard).
>
> I didn't look at the changes made to the input layer in details. Could
> anyone shed some light on this problem?
>
> Cheers

2004-01-12 10:33:12

by Vojtech Pavlik

[permalink] [raw]
Subject: Re: uk keyboard broken by input updates?

On Mon, Jan 12, 2004 at 10:21:04AM +0000, Kieran wrote:
> I have exactly the same problem using 2.6.1 and an IBM USB keyboard, not
> really had a chance to look into it yet though.

Can you check if this fixes it for you?

diff -Nru a/drivers/char/keyboard.c b/drivers/char/keyboard.c
--- a/drivers/char/keyboard.c Sun Jan 11 19:42:55 2004
+++ b/drivers/char/keyboard.c Sun Jan 11 19:42:55 2004
@@ -941,8 +941,8 @@
32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47,
48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63,
64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79,
- 80, 81, 82, 83, 84, 93, 86, 87, 88, 94, 95, 85,259,375,260, 90,
- 284,285,309,311,312, 91,327,328,329,331,333,335,336,337,338,339,
+ 80, 81, 82, 83, 43, 93, 86, 87, 88, 94, 95, 85,259,375,260, 90,
+ 284,285,309,298,312, 91,327,328,329,331,333,335,336,337,338,339,
367,288,302,304,350, 89,334,326,116,377,109,111,126,347,348,349,
360,261,262,263,298,376,100,101,321,316,373,286,289,102,351,355,
103,104,105,275,287,279,306,106,274,107,294,364,358,363,362,361,

--
Vojtech Pavlik
SuSE Labs, SuSE CR

2004-01-12 19:36:28

by Kieran

[permalink] [raw]
Subject: Re: uk keyboard broken by input updates?

> On Mon, Jan 12, 2004 at 10:21:04AM +0000, Kieran wrote:
>
>>I have exactly the same problem using 2.6.1 and an IBM USB keyboard, not
>>really had a chance to look into it yet though.
>
>
> Can you check if this fixes it for you?
>
> diff -Nru a/drivers/char/keyboard.c b/drivers/char/keyboard.c
> --- a/drivers/char/keyboard.c Sun Jan 11 19:42:55 2004
> +++ b/drivers/char/keyboard.c Sun Jan 11 19:42:55 2004
> @@ -941,8 +941,8 @@
> 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47,
> 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63,
> 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79,
> - 80, 81, 82, 83, 84, 93, 86, 87, 88, 94, 95, 85,259,375,260, 90,
> - 284,285,309,311,312, 91,327,328,329,331,333,335,336,337,338,339,
> + 80, 81, 82, 83, 43, 93, 86, 87, 88, 94, 95, 85,259,375,260, 90,
> + 284,285,309,298,312, 91,327,328,329,331,333,335,336,337,338,339,
> 367,288,302,304,350, 89,334,326,116,377,109,111,126,347,348,349,
> 360,261,262,263,298,376,100,101,321,316,373,286,289,102,351,355,
> 103,104,105,275,287,279,306,106,274,107,294,364,358,363,362,361,
>
works perfectly
##~~
:-)

2004-01-12 21:16:40

by Bastien Nocera

[permalink] [raw]
Subject: Re: uk keyboard broken by input updates?

On Mon, 2004-01-12 at 10:32, Vojtech Pavlik wrote:
> On Mon, Jan 12, 2004 at 10:21:04AM +0000, Kieran wrote:
> > I have exactly the same problem using 2.6.1 and an IBM USB keyboard, not
> > really had a chance to look into it yet though.
>
> Can you check if this fixes it for you?
>
> diff -Nru a/drivers/char/keyboard.c b/drivers/char/keyboard.c
> --- a/drivers/char/keyboard.c Sun Jan 11 19:42:55 2004
> +++ b/drivers/char/keyboard.c Sun Jan 11 19:42:55 2004
> @@ -941,8 +941,8 @@
> 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47,
> 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63,
> 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79,
> - 80, 81, 82, 83, 84, 93, 86, 87, 88, 94, 95, 85,259,375,260, 90,
> - 284,285,309,311,312, 91,327,328,329,331,333,335,336,337,338,339,
> + 80, 81, 82, 83, 43, 93, 86, 87, 88, 94, 95, 85,259,375,260, 90,
> + 284,285,309,298,312, 91,327,328,329,331,333,335,336,337,338,339,
> 367,288,302,304,350, 89,334,326,116,377,109,111,126,347,348,349,
> 360,261,262,263,298,376,100,101,321,316,373,286,289,102,351,355,
> 103,104,105,275,287,279,306,106,274,107,294,364,358,363,362,361,

Tested it, works great.

Thanks a lot for that patch.

---
Bastien Nocera <[email protected]>
If your boss is getting you down, look at him through the prongs of a
fork and imagine him in jail.

2004-01-23 08:58:34

by Bastien Nocera

[permalink] [raw]
Subject: Re: uk keyboard broken by input updates?

Hello Vojtech,

Is there any particular reason why this didn't make it into 2.6.2-rc1? I
just checked the 2.6.1 to 2.6.2-rc1 patch, and the only change to
char/keyboard.c seems to be a change in an #ifdef.

Cheers

On Mon, 2004-01-12 at 10:32, Vojtech Pavlik wrote:
> On Mon, Jan 12, 2004 at 10:21:04AM +0000, Kieran wrote:
> > I have exactly the same problem using 2.6.1 and an IBM USB keyboard, not
> > really had a chance to look into it yet though.
>
> Can you check if this fixes it for you?
>
> diff -Nru a/drivers/char/keyboard.c b/drivers/char/keyboard.c
> --- a/drivers/char/keyboard.c Sun Jan 11 19:42:55 2004
> +++ b/drivers/char/keyboard.c Sun Jan 11 19:42:55 2004
> @@ -941,8 +941,8 @@
> 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47,
> 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63,
> 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79,
> - 80, 81, 82, 83, 84, 93, 86, 87, 88, 94, 95, 85,259,375,260, 90,
> - 284,285,309,311,312, 91,327,328,329,331,333,335,336,337,338,339,
> + 80, 81, 82, 83, 43, 93, 86, 87, 88, 94, 95, 85,259,375,260, 90,
> + 284,285,309,298,312, 91,327,328,329,331,333,335,336,337,338,339,
> 367,288,302,304,350, 89,334,326,116,377,109,111,126,347,348,349,
> 360,261,262,263,298,376,100,101,321,316,373,286,289,102,351,355,
> 103,104,105,275,287,279,306,106,274,107,294,364,358,363,362,361,
---
Bastien Nocera <[email protected]>
Remember the 3 golden rules: 1. It was like that when I got here. 2. I
didn't do it. 3. (To your Boss) I like your style.

2004-01-23 09:28:53

by Andrew Morton

[permalink] [raw]
Subject: Re: uk keyboard broken by input updates?

Bastien Nocera <[email protected]> wrote:
>
> Hello Vojtech,
>
> Is there any particular reason why this didn't make it into 2.6.2-rc1? I
> just checked the 2.6.1 to 2.6.2-rc1 patch, and the only change to
> char/keyboard.c seems to be a change in an #ifdef.
>
> > - 80, 81, 82, 83, 84, 93, 86, 87, 88, 94, 95, 85,259,375,260, 90,
> > - 284,285,309,311,312, 91,327,328,329,331,333,335,336,337,338,339,
> > + 80, 81, 82, 83, 43, 93, 86, 87, 88, 94, 95, 85,259,375,260, 90,
> > + 284,285,309,298,312, 91,327,328,329,331,333,335,336,337,338,339,

These changes were merged post-2.6.2-rc1. Please test 2.6.2-rc1-mm2 or the
latest bk snapshot.

2004-01-23 09:38:33

by Bastien Nocera

[permalink] [raw]
Subject: Re: uk keyboard broken by input updates?

On Fri, 2004-01-23 at 09:29, Andrew Morton wrote:
> Bastien Nocera <[email protected]> wrote:
> >
> > Hello Vojtech,
> >
> > Is there any particular reason why this didn't make it into 2.6.2-rc1? I
> > just checked the 2.6.1 to 2.6.2-rc1 patch, and the only change to
> > char/keyboard.c seems to be a change in an #ifdef.
> >
> > > - 80, 81, 82, 83, 84, 93, 86, 87, 88, 94, 95, 85,259,375,260, 90,
> > > - 284,285,309,311,312, 91,327,328,329,331,333,335,336,337,338,339,
> > > + 80, 81, 82, 83, 43, 93, 86, 87, 88, 94, 95, 85,259,375,260, 90,
> > > + 284,285,309,298,312, 91,327,328,329,331,333,335,336,337,338,339,
>
> These changes were merged post-2.6.2-rc1. Please test 2.6.2-rc1-mm2 or the
> latest bk snapshot.

Thanks Andrew for the notice. I'll test out as soon as I can.

Cheers

---
Bastien Nocera <[email protected]>
Remember the 3 golden rules: 1. It was like that when I got here. 2. I
didn't do it. 3. (To your Boss) I like your style.