2021-03-05 09:57:50

by Gustavo A. R. Silva

Subject: [PATCH RESEND][next] hwmon: (corsair-cpro) Fix fall-through warnings for Clang

In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of letting the code fall
through to the next case.

Link: https://github.com/KSPP/linux/issues/115
Acked-by: Guenter Roeck <[email protected]>
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/hwmon/corsair-cpro.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/hwmon/corsair-cpro.c b/drivers/hwmon/corsair-cpro.c
index 591929ec217a..fa6aa4fc8b52 100644
--- a/drivers/hwmon/corsair-cpro.c
+++ b/drivers/hwmon/corsair-cpro.c
@@ -310,6 +310,7 @@ static int ccp_write(struct device *dev, enum hwmon_sensor_types type,
default:
break;
}
+ break;
default:
break;
}
--
2.27.0

2021-03-06 11:46:27

by Marius Zachmann

Subject: Re: [PATCH RESEND][next] hwmon: (corsair-cpro) Fix fall-through warnings for Clang

On 06.03.21 at 10:53:59 CET, Gustavo A. R. Silva wrote
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of letting the code fall
> through to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Acked-by: Guenter Roeck <[email protected]>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>

Acked-by: Marius Zachmann <[email protected]>

> ---
> drivers/hwmon/corsair-cpro.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwmon/corsair-cpro.c b/drivers/hwmon/corsair-cpro.c
> index 591929ec217a..fa6aa4fc8b52 100644
> --- a/drivers/hwmon/corsair-cpro.c
> +++ b/drivers/hwmon/corsair-cpro.c
> @@ -310,6 +310,7 @@ static int ccp_write(struct device *dev, enum hwmon_sensor_types type,
> default:
> break;
> }
> + break;
> default:
> break;
> }
>

2021-03-08 21:19:29

by Gustavo A. R. Silva

Subject: Re: [PATCH RESEND][next] hwmon: (corsair-cpro) Fix fall-through warnings for Clang

On Sat, Mar 06, 2021 at 11:39:35AM +0100, Marius Zachmann wrote:
> On 06.03.21 at 10:53:59 CET, Gustavo A. R. Silva wrote
> > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> > by explicitly adding a break statement instead of letting the code fall
> > through to the next case.
> >
> > Link: https://github.com/KSPP/linux/issues/115
> > Acked-by: Guenter Roeck <[email protected]>
> > Signed-off-by: Gustavo A. R. Silva <[email protected]>
>
> Acked-by: Marius Zachmann <[email protected]>

Thanks, Marius.

--
Gustavo

>
> > ---
> > drivers/hwmon/corsair-cpro.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/hwmon/corsair-cpro.c b/drivers/hwmon/corsair-cpro.c
> > index 591929ec217a..fa6aa4fc8b52 100644
> > --- a/drivers/hwmon/corsair-cpro.c
> > +++ b/drivers/hwmon/corsair-cpro.c
> > @@ -310,6 +310,7 @@ static int ccp_write(struct device *dev, enum hwmon_sensor_types type,
> > default:
> > break;
> > }
> > + break;
> > default:
> > break;
> > }
> >
>
>
>
>

2021-05-19 09:40:35

by Gustavo A. R. Silva

Subject: Re: [PATCH RESEND][next] hwmon: (corsair-cpro) Fix fall-through warnings for Clang

Hi all,

If you don't mind, I'm taking this in my -next[1] branch for v5.14.

Thanks
--
Gustavo

[1] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp

On 3/6/21 04:39, Marius Zachmann wrote:
> On 06.03.21 at 10:53:59 CET, Gustavo A. R. Silva wrote
>> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
>> by explicitly adding a break statement instead of letting the code fall
>> through to the next case.
>>
>> Link: https://github.com/KSPP/linux/issues/115
>> Acked-by: Guenter Roeck <[email protected]>
>> Signed-off-by: Gustavo A. R. Silva <[email protected]>
>
> Acked-by: Marius Zachmann <[email protected]>
>
>> ---
>> drivers/hwmon/corsair-cpro.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/hwmon/corsair-cpro.c b/drivers/hwmon/corsair-cpro.c
>> index 591929ec217a..fa6aa4fc8b52 100644
>> --- a/drivers/hwmon/corsair-cpro.c
>> +++ b/drivers/hwmon/corsair-cpro.c
>> @@ -310,6 +310,7 @@ static int ccp_write(struct device *dev, enum hwmon_sensor_types type,
>> default:
>> break;
>> }
>> + break;
>> default:
>> break;
>> }
>>
>
>
>
>