2004-04-03 08:42:48

by FabF

[permalink] [raw]
Subject: [PATCH 2.6.5rc2-mm2] Root_plug device check

Hi,

Here's a patch to check device in root_plug to avoid box freeze
when user gives bad ids.

Regards,
Fabian


Attachments:
root_plug1.diff (1.43 kB)

2004-04-07 19:04:06

by Greg KH

[permalink] [raw]
Subject: Re: [PATCH 2.6.5rc2-mm2] Root_plug device check

On Sat, Apr 03, 2004 at 10:42:33AM +0200, Fabian Frederick wrote:
> Hi,
>
> Here's a patch to check device in root_plug to avoid box freeze
> when user gives bad ids.

No, this patch is not acceptable. It's fine if the USB device is not
present when the module is loaded, any future programs run as root will
just not run.

So the current behavior is correct.

thanks,

greg k-h