2004-04-14 19:44:40

by FabF

[permalink] [raw]

Subject: [PATCH 2.6.5-mm4] vfs_readdir optimizations

---

-Remove unuseful gotos
-ENOENT case on DEADDIR

PS : mm5 doesn't appear on kernel.org main page.

Regards,
Fabian

---

Attachments:

readdir1.diff (874.00 B)

2004-04-14 20:16:04

by Chris Wright

[permalink] [raw]

Subject: Re: [PATCH 2.6.5-mm4] vfs_readdir optimizations

---

* Fabian Frederick ([email protected]) wrote:
> -Remove unuseful gotos
> -ENOENT case on DEADDIR

Couple things. It's useful to generate some numbers to show an
optimization is worthwhile. And code readability/maintainability is
important to maintain correctness. You may look at the assembly and
find that there is no real optimization with the changes you've proposed.

thanks,
-chris
--
Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net