2004-04-30 22:21:05

by FabF

[permalink] [raw]
Subject: [PATCH 2.6.6-rc3-mm1] Add maxthinktime to sysfs

Andrew,

Here's a patch to add the asio maxthinktime to sysfs.
Could you apply ?

Regards,
Fabian


Attachments:
maxthinktime1.diff (1.89 kB)

2004-04-30 22:41:15

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH 2.6.6-rc3-mm1] Add maxthinktime to sysfs

FabF <[email protected]> wrote:
>
> Here's a patch to add the asio maxthinktime to sysfs.

Why? Have you measured any benefit from varying it, and if so, what was
the result?

Badari, did you find any need to vary this in the AS tuning work which you
were doing? (What happened to that, btw?)

If we're going to expose this tunable to users it needs to be documented in
as-iosched.txt

2004-04-30 23:31:43

by FabF

[permalink] [raw]
Subject: Re: [PATCH 2.6.6-rc3-mm1] Add maxthinktime to sysfs

On Sat, 2004-05-01 at 00:42, Andrew Morton wrote:
> FabF <[email protected]> wrote:
> >
> > Here's a patch to add the asio maxthinktime to sysfs.
>
> Why? Have you measured any benefit from varying it, and if so, what was
> the result?

Andrew,

I notice huge variations in first seconds of a 10 client
throughput activity as attached (5,100,300 as maxthinktime).
It's just another parameter I'd like to play with ;)
Maybe this one's exposition is not important intrinsequely but we could
bring interesting combinations later ...


>
> Badari, did you find any need to vary this in the AS tuning work which you
> were doing? (What happened to that, btw?)
>
> If we're going to expose this tunable to users it needs to be documented in
> as-iosched.txt

I'm an absolute beginner Andrew ... Maybe someone more experienced could do that ?

PS:Attached the patch v2.

Best regards,
Fabian


Attachments:
ffbench11.txt (905.00 B)
maxthinktime2.diff (2.07 kB)
Download all attachments

2004-04-30 23:35:25

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH 2.6.6-rc3-mm1] Add maxthinktime to sysfs

FabF <[email protected]> wrote:
>
> I notice huge variations in first seconds of a 10 client
> throughput activity as attached (5,100,300 as maxthinktime).
> It's just another parameter I'd like to play with ;)

Fair enough. Interesting result.

Can you describe and/or publish ffbench?