2004-06-13 16:53:28

by areversat

[permalink] [raw]
Subject: Badness in local_bh_enable with eciadsl driver and kernel 2.6

Hi,
here is what most users get when running our driver (usb adsl modem
driver) with kernel 2.6.x. I'd like to know if it is a kernel bug or if
it has something to do with our driver.

Thanks

Badness in local_bh_enable at kernel/softirq.c:136
[<0212407a>] local_bh_enable+0x39/0x5c
[<42f0499e>] ppp_sync_push+0xd2/0x149 [ppp_synctty]
[<42f044aa>] ppp_sync_wakeup+0x1d/0x35 [ppp_synctty]
[<021d549f>] do_tty_hangup+0x12d/0x34c
[<021d652d>] release_dev+0x1c0/0x53f
[<0222e096>] usb_unbind_interface+0x41/0x50
[<021f4a8d>] device_release_driver+0x3c/0x46
[<0222e27e>] usb_driver_release_interface+0x2c/0x40
[<02235b32>] releaseintf+0x76/0x8f
[<021d6bc6>] tty_release+0x29/0x4e
[<02152baf>] __fput+0x3f/0xe3
[<0215189c>] filp_close+0x59/0x5f
[<02122006>] put_files_struct+0x57/0xaa
[<02122b45>] do_exit+0x211/0x390
[<02122dc0>] sys_exit_group+0x0/0xd
[<0212986b>] get_signal_to_deliver+0x34c/0x372
[<02107208>] do_signal+0x4e/0xbb
[<02160dc3>] file_ioctl+0x167/0x17b
[<02161010>] sys_ioctl+0x239/0x243
[<0210729d>] do_notify_resume+0x28/0x37
--
Pour trouver les limites du possible il faut tenter l'impossible.


Attachments:
signature.asc (189.00 B)
Ceci est une partie de message num?riquement sign?e.

2004-06-13 16:56:41

by areversat

[permalink] [raw]
Subject: Re: Badness in local_bh_enable with eciadsl driver and kernel 2.6

I forgot one thing : this happends when they shut down the computer
without killing pppd.

Le dim 13/06/2004 ? 18:53, areversat a ?crit :
> Hi,
> here is what most users get when running our driver (usb adsl modem
> driver) with kernel 2.6.x. I'd like to know if it is a kernel bug or if
> it has something to do with our driver.
>
> Thanks
>
> Badness in local_bh_enable at kernel/softirq.c:136
> [<0212407a>] local_bh_enable+0x39/0x5c
> [<42f0499e>] ppp_sync_push+0xd2/0x149 [ppp_synctty]
> [<42f044aa>] ppp_sync_wakeup+0x1d/0x35 [ppp_synctty]
> [<021d549f>] do_tty_hangup+0x12d/0x34c
> [<021d652d>] release_dev+0x1c0/0x53f
> [<0222e096>] usb_unbind_interface+0x41/0x50
> [<021f4a8d>] device_release_driver+0x3c/0x46
> [<0222e27e>] usb_driver_release_interface+0x2c/0x40
> [<02235b32>] releaseintf+0x76/0x8f
> [<021d6bc6>] tty_release+0x29/0x4e
> [<02152baf>] __fput+0x3f/0xe3
> [<0215189c>] filp_close+0x59/0x5f
> [<02122006>] put_files_struct+0x57/0xaa
> [<02122b45>] do_exit+0x211/0x390
> [<02122dc0>] sys_exit_group+0x0/0xd
> [<0212986b>] get_signal_to_deliver+0x34c/0x372
> [<02107208>] do_signal+0x4e/0xbb
> [<02160dc3>] file_ioctl+0x167/0x17b
> [<02161010>] sys_ioctl+0x239/0x243
> [<0210729d>] do_notify_resume+0x28/0x37
--
Pour trouver les limites du possible il faut tenter l'impossible.


Attachments:
signature.asc (189.00 B)
Ceci est une partie de message num?riquement sign?e.

2004-06-13 17:07:14

by Arjan van de Ven

[permalink] [raw]
Subject: Re: Badness in local_bh_enable with eciadsl driver and kernel 2.6

On Sun, 2004-06-13 at 18:53, areversat wrote:
> Hi,
> here is what most users get when running our driver (usb adsl modem
> driver) with kernel 2.6.x. I'd like to know if it is a kernel bug or if
> it has something to do with our driver.

I think you forgot to attach your driver (or an URL for it)....


Attachments:
signature.asc (189.00 B)
This is a digitally signed message part

2004-06-13 17:10:13

by areversat

[permalink] [raw]
Subject: Re: Badness in local_bh_enable with eciadsl driver and kernel 2.6

Oups yes sorry you can find it (i also forgot to say it's a usermode
driver) at http://eciadsl.flashtux.org

Le dim 13/06/2004 ? 19:07, Arjan van de Ven a ?crit :
> On Sun, 2004-06-13 at 18:53, areversat wrote:
> > Hi,
> > here is what most users get when running our driver (usb adsl modem
> > driver) with kernel 2.6.x. I'd like to know if it is a kernel bug or if
> > it has something to do with our driver.
>
> I think you forgot to attach your driver (or an URL for it)....
--
Pour trouver les limites du possible il faut tenter l'impossible.


Attachments:
signature.asc (189.00 B)
Ceci est une partie de message num?riquement sign?e.

2004-06-13 17:12:58

by Paul Fulghum

[permalink] [raw]
Subject: Re: Badness in local_bh_enable with eciadsl driver and kernel 2.6

On Sun, 2004-06-13 at 11:53, areversat wrote:
> Hi,
> here is what most users get when running our driver (usb adsl modem
> driver) with kernel 2.6.x. I'd like to know if it is a kernel bug or if
> it has something to do with our driver.
>
> Thanks
>
> Badness in local_bh_enable at kernel/softirq.c:136
> [<0212407a>] local_bh_enable+0x39/0x5c
> [<42f0499e>] ppp_sync_push+0xd2/0x149 [ppp_synctty]
> [<42f044aa>] ppp_sync_wakeup+0x1d/0x35 [ppp_synctty]
> [<021d549f>] do_tty_hangup+0x12d/0x34c
> [<021d652d>] release_dev+0x1c0/0x53f
> [<0222e096>] usb_unbind_interface+0x41/0x50
> [<021f4a8d>] device_release_driver+0x3c/0x46
> [<0222e27e>] usb_driver_release_interface+0x2c/0x40
> [<02235b32>] releaseintf+0x76/0x8f
> [<021d6bc6>] tty_release+0x29/0x4e
> [<02152baf>] __fput+0x3f/0xe3
> [<0215189c>] filp_close+0x59/0x5f
> [<02122006>] put_files_struct+0x57/0xaa
> [<02122b45>] do_exit+0x211/0x390
> [<02122dc0>] sys_exit_group+0x0/0xd
> [<0212986b>] get_signal_to_deliver+0x34c/0x372
> [<02107208>] do_signal+0x4e/0xbb
> [<02160dc3>] file_ioctl+0x167/0x17b
> [<02161010>] sys_ioctl+0x239/0x243
> [<0210729d>] do_notify_resume+0x28/0x37

Try the attached patch.

--
Paul Fulghum
[email protected]


Attachments:
patch-ppp_synctty.c (8.59 kB)

2004-06-14 13:53:52

by areversat

[permalink] [raw]
Subject: Re: Badness in local_bh_enable with eciadsl driver and kernel 2.6

Ok someone tried the patch for me (i don't have the modem here). And it
seems to work just fine : it removes the message i reported. It may need
more extensive tests but it would be nice to think about including it to
the kernel.
Thanks

Antoine
Le dim 13/06/2004 ? 19:10, Paul Fulghum a ?crit :
> On Sun, 2004-06-13 at 11:53, areversat wrote:
> > Hi,
> > here is what most users get when running our driver (usb adsl modem
> > driver) with kernel 2.6.x. I'd like to know if it is a kernel bug or if
> > it has something to do with our driver.
> >
> > Thanks
> >
> > Badness in local_bh_enable at kernel/softirq.c:136
> > [<0212407a>] local_bh_enable+0x39/0x5c
> > [<42f0499e>] ppp_sync_push+0xd2/0x149 [ppp_synctty]
> > [<42f044aa>] ppp_sync_wakeup+0x1d/0x35 [ppp_synctty]
> > [<021d549f>] do_tty_hangup+0x12d/0x34c
> > [<021d652d>] release_dev+0x1c0/0x53f
> > [<0222e096>] usb_unbind_interface+0x41/0x50
> > [<021f4a8d>] device_release_driver+0x3c/0x46
> > [<0222e27e>] usb_driver_release_interface+0x2c/0x40
> > [<02235b32>] releaseintf+0x76/0x8f
> > [<021d6bc6>] tty_release+0x29/0x4e
> > [<02152baf>] __fput+0x3f/0xe3
> > [<0215189c>] filp_close+0x59/0x5f
> > [<02122006>] put_files_struct+0x57/0xaa
> > [<02122b45>] do_exit+0x211/0x390
> > [<02122dc0>] sys_exit_group+0x0/0xd
> > [<0212986b>] get_signal_to_deliver+0x34c/0x372
> > [<02107208>] do_signal+0x4e/0xbb
> > [<02160dc3>] file_ioctl+0x167/0x17b
> > [<02161010>] sys_ioctl+0x239/0x243
> > [<0210729d>] do_notify_resume+0x28/0x37
>
> Try the attached patch.
>
> --
> Paul Fulghum
[email protected]


Attachments:
signature.asc (189.00 B)
Ceci est une partie de message num?riquement sign?e.

2004-06-14 14:38:48

by Paul Fulghum

[permalink] [raw]
Subject: Re: Badness in local_bh_enable with eciadsl driver and kernel 2.6

areversat wrote:
> Ok someone tried the patch for me (i don't have the modem here). And it
> seems to work just fine : it removes the message i reported. It may need
> more extensive tests but it would be nice to think about including it to
> the kernel.

This patch is well tested and understood and I'm confident
it will be accepted. But Linus indicated 2.6.7-rc is closed
to new stuff so I have not pushed it to Andrew yet.

2.6.8 seems likely.

--
Paul Fulghum
[email protected]