2004-06-16 13:00:20

by Benoît Dejean

[permalink] [raw]
Subject: 2.6.7 warnings

drivers/video/fbmem.c: In function `fb_cursor':
drivers/video/fbmem.c:933: warning: passing arg 1 of `copy_from_user'
discards qualifiers from pointer target type

sound/pci/via82xx.c: In function `snd_via82xx_probe':
sound/pci/via82xx.c:2252: warning: statement with no effect
(cpp shows that this statement is reduced to -22;)

--
Benoît Dejean
JID: [email protected]
http://gdesklets.gnomedesktop.org
http://www.paulla.asso.fr


Attachments:
signature.asc (189.00 B)
Ceci est une partie de message num?riquement sign

2004-06-16 16:36:12

by Takashi Iwai

[permalink] [raw]
Subject: Re: 2.6.7 warnings

At Wed, 16 Jun 2004 14:55:17 +0200,
Beno?t Dejean wrote:
>
> sound/pci/via82xx.c: In function `snd_via82xx_probe':
> sound/pci/via82xx.c:2252: warning: statement with no effect
> (cpp shows that this statement is reduced to -22;)

The patch below should fix this.


Takashi

--- linux-2.6.7/include/sound/core.h-dist 2004-06-16 17:57:34.288215560 +0200
+++ linux-2.6.7/include/sound/core.h 2004-06-16 17:58:19.638890254 +0200
@@ -223,9 +223,9 @@ int snd_card_pci_resume(struct pci_dev *
static inline int snd_power_wait(snd_card_t *card, unsigned int state, struct file *file) { return 0; }
#define snd_power_get_state(card) SNDRV_CTL_POWER_D0
#define snd_power_change_state(card, state) do { (void)(card); } while (0)
-#define snd_card_set_pm_callback(card,suspend,resume,data) -EINVAL
-#define snd_card_set_dev_pm_callback(card,suspend,resume,data) -EINVAL
-#define snd_card_set_isa_pm_callback(card,suspend,resume,data) -EINVAL
+#define snd_card_set_pm_callback(card,suspend,resume,data)
+#define snd_card_set_dev_pm_callback(card,suspend,resume,data)
+#define snd_card_set_isa_pm_callback(card,suspend,resume,data)
#define SND_PCI_PM_CALLBACKS
#endif