2004-06-19 22:39:46

by FabF

[permalink] [raw]
Subject: [PATCH 2.6.7] ext3 fill_super reporting

Andrew,

This patch does the following :
-Explicit max_per_group authorized for block, fragments, inodes
-Remove groupmax recalculations
-When mounting ext2 or ^has_journal , we know filesystem is extX
relevant.


btw, I see a FIXME in journal_update for new journal creation.Does it
mean we should patch to have e.g. journalupdate=<filename> or that note
is obsolete ?

Regards,
FabF


Attachments:
fillsuper1.diff (2.12 kB)

2004-06-19 23:17:05

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH 2.6.7] ext3 fill_super reporting

FabF <[email protected]> wrote:
>
> Andrew,
>
> This patch does the following :

> -Explicit max_per_group authorized for block, fragments, inodes

Sorry, but this is just too trivial to be worth the processing. The
compiler is perfectly capable of retaining the `blocksize * 8' result for
later use and this part of your patch actually increases the code size
slightly.

> -Remove groupmax recalculations

I don't know what this means.

> -When mounting ext2 or ^has_journal , we know filesystem is extX
> relevant.
>
>
> btw, I see a FIXME in journal_update for new journal creation.

There is no such thing as journal_update. I assume you're referring to the
handling of the "journal=update" mount option. Please be more careful when
identifying these things.

> Does it
> mean we should patch to have e.g. journalupdate=<filename> or that note
> is obsolete ?

No, I see no need to be able to convert an ext2 filesystem to ext3 within
the kernel. Nobody will bother to work on this.