I tried this patch alone on top of 2.6.9-rc1 and tg3 is still broken for
me on JS20 blades. Was there another patch I should have applied in
conjunction with this?
Thanks,
Paul Larson
On Mon, 2004-08-30 at 18:11, David S. Miller wrote:
> Michael Chan at Broadcom spotted the bug.
>
> Things are totally broken if the switch/hub does not support
> autonegotiation. Checking for the MAC_STATUS_SIGNAL_DET bit
> in the tg3 polling timer fixes the problem.
>
> This is probably why it worked for you and doesn't with the
> IBM blades as blades are more likely to be connected to
> non-autoneg'ing devices.
>
> ===== drivers/net/tg3.c 1.199 vs edited =====
> --- 1.199/drivers/net/tg3.c 2004-08-18 19:52:35 -07:00
> +++ edited/drivers/net/tg3.c 2004-08-30 15:08:07 -07:00
> @@ -5602,7 +5602,8 @@
> need_setup = 1;
> }
> if (! netif_carrier_ok(tp->dev) &&
> - (mac_stat & MAC_STATUS_PCS_SYNCED)) {
> + (mac_stat & (MAC_STATUS_PCS_SYNCED |
> + MAC_STATUS_SIGNAL_DET))) {
> need_setup = 1;
> }
> if (need_setup) {
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Paul Larson wrote:
> I tried this patch alone on top of 2.6.9-rc1 and tg3 is still broken for
> me on JS20 blades. Was there another patch I should have applied in
> conjunction with this?
>
Is this with or without autonegotiation enabled on the switch?
> Thanks,
> Paul Larson
>
> On Mon, 2004-08-30 at 18:11, David S. Miller wrote:
>
>>Michael Chan at Broadcom spotted the bug.
>>
>>Things are totally broken if the switch/hub does not support
>>autonegotiation. Checking for the MAC_STATUS_SIGNAL_DET bit
>>in the tg3 polling timer fixes the problem.
>>
>>This is probably why it worked for you and doesn't with the
>>IBM blades as blades are more likely to be connected to
>>non-autoneg'ing devices.
>>
>>===== drivers/net/tg3.c 1.199 vs edited =====
>>--- 1.199/drivers/net/tg3.c 2004-08-18 19:52:35 -07:00
>>+++ edited/drivers/net/tg3.c 2004-08-30 15:08:07 -07:00
>>@@ -5602,7 +5602,8 @@
>> need_setup = 1;
>> }
>> if (! netif_carrier_ok(tp->dev) &&
>>- (mac_stat & MAC_STATUS_PCS_SYNCED)) {
>>+ (mac_stat & (MAC_STATUS_PCS_SYNCED |
>>+ MAC_STATUS_SIGNAL_DET))) {
>> need_setup = 1;
>> }
>> if (need_setup) {
>>-
>>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>>the body of a message to [email protected]
>>More majordomo info at http://vger.kernel.org/majordomo-info.html
>>Please read the FAQ at http://www.tux.org/lkml/
>>
>
>
- --
Mike Waychison
Sun Microsystems, Inc.
1 (650) 352-5299 voice
1 (416) 202-8336 voice
http://www.sun.com
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
NOTICE: The opinions expressed in this email are held by me,
and may not represent the views of Sun Microsystems, Inc.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
iD8DBQFBOMPcdQs4kOxk3/MRAoJiAJoCZV1AKTQcOiOz0jNX1eZq9ZkiYACfaYDc
lWGl0C2xVNRuPuaKqt8/J90=
=mWO4
-----END PGP SIGNATURE-----
On Fri, 03 Sep 2004 14:12:58 -0500
Paul Larson <[email protected]> wrote:
> I tried this patch alone on top of 2.6.9-rc1 and tg3 is still broken for
> me on JS20 blades. Was there another patch I should have applied in
> conjunction with this?
Use current 2.6.9 which has all of the updates.
The driver should be version 3.9
Paul> I tried this patch alone on top of 2.6.9-rc1 and tg3 is
Paul> still broken for me on JS20 blades. Was there another patch
Paul> I should have applied in conjunction with this?
Me too -- I copied the latest BK tg3.c/tg3.h to my 2.6.8.1 tree and
tried it on my JS20 and it didn't work. Unfortunately the JS20 blade
only has serial-over-LAN for the console, which also dies as soon as
tg3 gets loaded, so I'm not sure exactly what happened.
Mike> Is this with or without autonegotiation enabled on the switch?
I believe that the internal ports of the BladeCenter switch are always
locked to full-duplex gigabit operation (ie no autoneg). In the
switch management GUI, there is a pull-down menu for setting
Speed/Duplex of external ports, but for internal ports to the blades,
there is no menu (just a hard-coded display of 1000/Full).
Thanks,
Roland
On Fri, 03 Sep 2004 13:18:11 -0700
Roland Dreier <[email protected]> wrote:
> Paul> I tried this patch alone on top of 2.6.9-rc1 and tg3 is
> Paul> still broken for me on JS20 blades. Was there another patch
> Paul> I should have applied in conjunction with this?
>
> Me too -- I copied the latest BK tg3.c/tg3.h to my 2.6.8.1 tree and
> tried it on my JS20 and it didn't work.
What do you mean by "latest"? If it doesn't indicate driver
version 3.9 it is not the latest.
Please make sure you try current sources, I've had nothing
but positive reports for IBM blades from people actually
using the correct current 3.9 driver.
David> What do you mean by "latest"? If it doesn't indicate
David> driver version 3.9 it is not the latest.
"latest" == pulled last night. (And yes it says version 3.9)
David> Please make sure you try current sources, I've had nothing
David> but positive reports for IBM blades from people actually
David> using the correct current 3.9 driver.
I'll give it another try -- it could also be my chassis which is a
little flaky.
Thanks,
Roland
David> Please make sure you try current sources, I've had nothing
David> but positive reports for IBM blades from people actually
David> using the correct current 3.9 driver.
I tried it with a full build of a BK tree pulled last night, and it
definitely didn't work. Some relevant output:
tg3.c:v3.9 (August 30, 2004)
eth0: Tigon3 [partno(none) rev 2003 PHY(serdes)] (PCIX:133MHz:64-bit) 10/100/1000BaseT Ethernet 00:0d:60:1e:88:56
eth0: HostTXDS[1] RXcsums[1] LinkChgREG[0] MIirq[0] ASF[1] Split[0] WireSpeed[1] TSOcap[0]
eth1: Tigon3 [partno(none) rev 2003 PHY(serdes)] (PCIX:133MHz:64-bit) 10/100/1000BaseT Ethernet 00:0d:60:1e:88:57
eth1: HostTXDS[1] RXcsums[1] LinkChgREG[0] MIirq[0] ASF[0] Split[0] WireSpeed[1] TSOcap[1]
and then as soon as the init scripts try to bring up the interface:
Setting up network interfaces:
lo
lo IP address: 127.0.0.1/8 done
dummy0
dummy0 No configuration found for dummy0 unused
eth0 device: Broadcom Corporation NetXtreme BCM5
system>
system> console -T system:blade[11]
SOL is not ready
(the last three lines are the management console taking over again
after the serial-over-LAN has died)
Just to be clear, I'm running a ppc64 kernel on a JS20 blade (dual PPC
970) with BCM5704S. The HS20 blade (dual Xeon) also has a BCM5703X
but I haven't tried the latest driver on one of those yet.
Thanks,
Roland
> Setting up network interfaces:
> lo
> lo IP address: 127.0.0.1/8 done
> dummy0
> dummy0 No configuration found for dummy0 unused
> eth0 device: Broadcom Corporation NetXtreme BCM5
> system>
> system> console -T system:blade[11]
> SOL is not ready
Whenever an adapter reset is done (eg ifconfig up) on the same adapter
that SoL is using, you'll lose SoL. SoL usually comes back, although
I've not had much luck ever since the Sun auto negotiation patch went
in. One fix/workaround to not losing your SoL connection is having the
network go only over eth1 (assuming you have two switch modules).
Thanks,
Jake
Jake> Whenever an adapter reset is done (eg ifconfig up) on the
Jake> same adapter that SoL is using, you'll lose SoL. SoL
Jake> usually comes back, although I've not had much luck ever
Jake> since the Sun auto negotiation patch went in. One
Jake> fix/workaround to not losing your SoL connection is having
Jake> the network go only over eth1 (assuming you have two switch
Jake> modules).
Thanks -- unfortunately I only have one switch module :(
With the 3.9 tg3 driver, neither SoL nor the real network seems to
ever come back. As far as I can tell, the network is dead (and
without SoL there's no way for me to see what happens to the kernel).
Have you had success with the latest tg3 on JS20?
- R.
> With the 3.9 tg3 driver, neither SoL nor the real network seems to
> ever come back. As far as I can tell, the network is dead (and
> without SoL there's no way for me to see what happens to the kernel).
>
> Have you had success with the latest tg3 on JS20?
I've had mixed results. On some of my blades it never works. On others
it will come up every third attempt or so.
Thanks,
Jake
> I've had mixed results. On some of my blades it never works. On others
> it will come up every third attempt or so.
2.6 BK as of 2 days ago wasnt working on my JS20 either. Ive been
meaning to look closer but havent had a chance yet.
Anton
I've had no success on any of the blades or bladecenters I've tried it
on.
On Wed, 2004-09-08 at 07:34, Jake Moilanen wrote:
> > With the 3.9 tg3 driver, neither SoL nor the real network seems to
> > ever come back. As far as I can tell, the network is dead (and
> > without SoL there's no way for me to see what happens to the kernel).
> >
> > Have you had success with the latest tg3 on JS20?
>
> I've had mixed results. On some of my blades it never works. On others
> it will come up every third attempt or so.
>
> Thanks,
> Jake
I just realized that I forgot to mention, the latest kernel I tried on
with 2.6.9-rc1-bk15, which was still broken, network doesn't work.
However, the autoneg failed messages in dmesg were gone. I tried
multiple reboots to see if it would work/not work at random and I never
saw it work even once.
Thanks,
Paul Larson
On Wed, 2004-09-08 at 08:55, Paul Larson wrote:
> I've had no success on any of the blades or bladecenters I've tried it
> on.
>
> On Wed, 2004-09-08 at 07:34, Jake Moilanen wrote:
> > > With the 3.9 tg3 driver, neither SoL nor the real network seems to
> > > ever come back. As far as I can tell, the network is dead (and
> > > without SoL there's no way for me to see what happens to the kernel).
> > >
> > > Have you had success with the latest tg3 on JS20?
> >
> > I've had mixed results. On some of my blades it never works. On others
> > it will come up every third attempt or so.
> >
> > Thanks,
> > Jake
On Wed, 8 Sep 2004 23:07:28 +1000
Anton Blanchard <[email protected]> wrote:
>
> > I've had mixed results. On some of my blades it never works. On others
> > it will come up every third attempt or so.
>
> 2.6 BK as of 2 days ago wasnt working on my JS20 either. Ive been
> meaning to look closer but havent had a chance yet.
Are you going to work on this soon Anton? I will cook up some
debugging patches, this bug sucks and I want to fix it soon.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
David S. Miller wrote:
> On Wed, 8 Sep 2004 23:07:28 +1000
> Anton Blanchard <[email protected]> wrote:
>
>
>>
>>
>>>I've had mixed results. On some of my blades it never works. On others
>>>it will come up every third attempt or so.
>>
>>2.6 BK as of 2 days ago wasnt working on my JS20 either. Ive been
>>meaning to look closer but havent had a chance yet.
>
>
> Are you going to work on this soon Anton? I will cook up some
> debugging patches, this bug sucks and I want to fix it soon.
I've gone through the changes you've made lately and I found a thinko,
patch attached.
With this patch, I can turn off autoneg on our b1600's switch and the
b200x falls back to 1000FD as required.
Signed-Off: Mike Waychison <[email protected]>
- --
Mike Waychison
Sun Microsystems, Inc.
1 (650) 352-5299 voice
1 (416) 202-8336 voice
http://www.sun.com
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
NOTICE: The opinions expressed in this email are held by me,
and may not represent the views of Sun Microsystems, Inc.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
iD8DBQFBR26QdQs4kOxk3/MRAoCrAJ95xamjKjB1gSnNa63PrncjvHEfWwCghxkJ
UOQQ0P+4kc/FnbwfeXEaGHA=
=G6li
-----END PGP SIGNATURE-----
On Tue, 14 Sep 2004 18:20:02 -0400
Mike Waychison <[email protected]> wrote:
> I've gone through the changes you've made lately and I found a thinko,
> patch attached.
>
> With this patch, I can turn off autoneg on our b1600's switch and the
> b200x falls back to 1000FD as required.
>
> Signed-Off: Mike Waychison <[email protected]>
Thanks Mike, come up to SF and I'll buy you a round
or two. :-)
> I've gone through the changes you've made lately and I found a thinko,
> patch attached.
>
> With this patch, I can turn off autoneg on our b1600's switch and the
> b200x falls back to 1000FD as required.
>
> Signed-Off: Mike Waychison <[email protected]>
>
This is working on my JS20. Nice work Mike.
Jake
Works on my JS20 as well. Thanks!
- Roland