Subject: [PATCH 1/2] video: fbdev: wm8505fb: fix sparse warnings about using incorrect types

Use ->screen_buffer instead of ->screen_base to fix sparse warnings.

[ Please see commit 17a7b0b4d974 ("fb.h: Provide alternate screen_base
pointer") for details. ]

Signed-off-by: Bartlomiej Zolnierkiewicz <[email protected]>
---
Resend with Tony & linux-arm ML added to Cc:.

drivers/video/fbdev/wm8505fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Index: b/drivers/video/fbdev/wm8505fb.c
===================================================================
--- a/drivers/video/fbdev/wm8505fb.c
+++ b/drivers/video/fbdev/wm8505fb.c
@@ -339,7 +339,7 @@ static int wm8505fb_probe(struct platfor

fbi->fb.fix.smem_start = fb_mem_phys;
fbi->fb.fix.smem_len = fb_mem_len;
- fbi->fb.screen_base = fb_mem_virt;
+ fbi->fb.screen_buffer = fb_mem_virt;
fbi->fb.screen_size = fb_mem_len;

fbi->contrast = 0x10;


2020-01-17 19:00:00

by Sam Ravnborg

[permalink] [raw]
Subject: Re: [PATCH 1/2] video: fbdev: wm8505fb: fix sparse warnings about using incorrect types

On Thu, Jan 16, 2020 at 03:56:50PM +0100, Bartlomiej Zolnierkiewicz wrote:
> Use ->screen_buffer instead of ->screen_base to fix sparse warnings.
>
> [ Please see commit 17a7b0b4d974 ("fb.h: Provide alternate screen_base
> pointer") for details. ]
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <[email protected]>
Acked-by: Sam Ravnborg <[email protected]>
> ---
> Resend with Tony & linux-arm ML added to Cc:.
>
> drivers/video/fbdev/wm8505fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: b/drivers/video/fbdev/wm8505fb.c
> ===================================================================
> --- a/drivers/video/fbdev/wm8505fb.c
> +++ b/drivers/video/fbdev/wm8505fb.c
> @@ -339,7 +339,7 @@ static int wm8505fb_probe(struct platfor
>
> fbi->fb.fix.smem_start = fb_mem_phys;
> fbi->fb.fix.smem_len = fb_mem_len;
> - fbi->fb.screen_base = fb_mem_virt;
> + fbi->fb.screen_buffer = fb_mem_virt;
> fbi->fb.screen_size = fb_mem_len;
>
> fbi->contrast = 0x10;
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

Subject: Re: [PATCH 1/2] video: fbdev: wm8505fb: fix sparse warnings about using incorrect types


On 1/17/20 7:58 PM, Sam Ravnborg wrote:
> On Thu, Jan 16, 2020 at 03:56:50PM +0100, Bartlomiej Zolnierkiewicz wrote:
>> Use ->screen_buffer instead of ->screen_base to fix sparse warnings.
>>
>> [ Please see commit 17a7b0b4d974 ("fb.h: Provide alternate screen_base
>> pointer") for details. ]
>>
>> Signed-off-by: Bartlomiej Zolnierkiewicz <[email protected]>
> Acked-by: Sam Ravnborg <[email protected]>

Thanks, patch queued for v5.7.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics