The coccinelle check report:
./drivers/scsi/csiostor/csio_mb.c:1554:46-52: ERROR: application of
sizeof to pointer
Signed-off-by: Ran Sun <[email protected]>
---
sound/soc/sof/ipc4-topology.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/sof/ipc4-topology.c
b/sound/soc/sof/ipc4-topology.c
index a4e1a70b607d..2dbe87dbd239 100644
--- a/sound/soc/sof/ipc4-topology.c
+++ b/sound/soc/sof/ipc4-topology.c
@@ -218,7 +218,7 @@ static int sof_ipc4_get_audio_fmt(struct
snd_soc_component *scomp,
ret = sof_update_ipc_object(scomp, available_fmt,
SOF_AUDIO_FMT_NUM_TOKENS, swidget->tuples,
- swidget->num_tuples, sizeof(available_fmt), 1);
+ swidget->num_tuples, sizeof(*available_fmt), 1);
if (ret) {
dev_err(scomp->dev, "Failed to parse audio format token count\n");
return ret;
On 7/20/23 10:43, [email protected] wrote:
> The coccinelle check report:
> ./drivers/scsi/csiostor/csio_mb.c:1554:46-52: ERROR: application of
> sizeof to pointer
>
> Signed-off-by: Ran Sun <[email protected]>
> ---
> sound/soc/sof/ipc4-topology.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/sof/ipc4-topology.c b/sound/soc/sof/ipc4-topology.c
> index a4e1a70b607d..2dbe87dbd239 100644
> --- a/sound/soc/sof/ipc4-topology.c
> +++ b/sound/soc/sof/ipc4-topology.c
> @@ -218,7 +218,7 @@ static int sof_ipc4_get_audio_fmt(struct
> snd_soc_component *scomp,
>
> ret = sof_update_ipc_object(scomp, available_fmt,
> SOF_AUDIO_FMT_NUM_TOKENS, swidget->tuples,
> - swidget->num_tuples, sizeof(available_fmt), 1);
> + swidget->num_tuples, sizeof(*available_fmt), 1);
> if (ret) {
> dev_err(scomp->dev, "Failed to parse audio format token count\n");
> return ret;
you need to Cc: maintainers and SOF folks who are knowledgeable on IPC4.
On 20/07/2023 11:43, [email protected] wrote:
> The coccinelle check report:
> ./drivers/scsi/csiostor/csio_mb.c:1554:46-52: ERROR: application of
> sizeof to pointer
Please include the maintainers for patches to enusre they reach the
correct audience, if in doubt who should be on TO/CC, use the
scripts/get_maintainer.pl <patch file>
Acked-by: Peter Ujfalusi <[email protected]>
> Signed-off-by: Ran Sun <[email protected]>
> ---
> sound/soc/sof/ipc4-topology.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/sof/ipc4-topology.c b/sound/soc/sof/ipc4-topology.c
> index a4e1a70b607d..2dbe87dbd239 100644
> --- a/sound/soc/sof/ipc4-topology.c
> +++ b/sound/soc/sof/ipc4-topology.c
> @@ -218,7 +218,7 @@ static int sof_ipc4_get_audio_fmt(struct
> snd_soc_component *scomp,
>
> ret = sof_update_ipc_object(scomp, available_fmt,
> SOF_AUDIO_FMT_NUM_TOKENS, swidget->tuples,
> - swidget->num_tuples, sizeof(available_fmt), 1);
> + swidget->num_tuples, sizeof(*available_fmt), 1);
The second last parameter is in essence unused since we only update a
single item.
The patch is correct in a semantic way but the original code worked
correctly.
> if (ret) {
> dev_err(scomp->dev, "Failed to parse audio format token count\n");
> return ret;
--
Péter
On Thu, Jul 20, 2023 at 04:43:57PM +0800, [email protected] wrote:
> The coccinelle check report:
> ./drivers/scsi/csiostor/csio_mb.c:1554:46-52: ERROR: application of
> sizeof to pointer
This doesn't apply against current code, please check and resend.