2004-11-14 13:27:12

by Alexander Nyberg

Subject: [PATCH] x86_64: assign_irq_vector should not be marked __init

Hej Linus

This box crashed at startup today and I noticed that some modules will
need to have assign_irq_vector() available although it is marked as __init.
Looks like it was done for i386 in but not x86_64...


Signed off by: Alexander Nyberg <[email protected]>

===== arch/x86_64/kernel/io_apic.c 1.38 vs edited =====
--- 1.38/arch/x86_64/kernel/io_apic.c 2004-10-28 09:39:50 +02:00
+++ edited/arch/x86_64/kernel/io_apic.c 2004-11-14 14:03:50 +01:00
@@ -654,11 +654,7 @@
/* irq_vectors is indexed by the sum of all RTEs in all I/O APICs. */
u8 irq_vector[NR_IRQ_VECTORS] = { FIRST_DEVICE_VECTOR , 0 };

-#ifdef CONFIG_PCI_MSI
int assign_irq_vector(int irq)
-#else
-int __init assign_irq_vector(int irq)
-#endif
{
static int current_vector = FIRST_DEVICE_VECTOR, offset = 0;

2004-11-14 21:27:51

by Andi Kleen

Subject: Re: [PATCH] x86_64: assign_irq_vector should not be marked __init

On Sun, Nov 14, 2004 at 02:26:50PM +0100, Alexander Nyberg wrote:
> Hej Linus
>
> This box crashed at startup today and I noticed that some modules will
> need to have assign_irq_vector() available although it is marked as __init.
> Looks like it was done for i386 in but not x86_64...

Thanks added to my tree.

-Andi