2017-11-16 04:33:17

by Arvind Yadav

[permalink] [raw]
Subject: [PATCH 01/12] isdn: hisax: Fix pnp_irq's error checking for setup_asuscom

The pnp_irq() function returns -1 if an error occurs.
pnp_irq() error checking for zero is not correct.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/isdn/hisax/asuscom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/isdn/hisax/asuscom.c b/drivers/isdn/hisax/asuscom.c
index 62f9c43..74c8714 100644
--- a/drivers/isdn/hisax/asuscom.c
+++ b/drivers/isdn/hisax/asuscom.c
@@ -348,7 +348,7 @@ int setup_asuscom(struct IsdnCard *card)
}
card->para[1] = pnp_port_start(pnp_d, 0);
card->para[0] = pnp_irq(pnp_d, 0);
- if (!card->para[0] || !card->para[1]) {
+ if (card->para[0] == -1 || !card->para[1]) {
printk(KERN_ERR "AsusPnP:some resources are missing %ld/%lx\n",
card->para[0], card->para[1]);
pnp_disable_dev(pnp_d);
--
1.9.1


From 1584780507407257838@xxx Wed Nov 22 15:27:47 +0000 2017
X-GM-THRID: 1584780128559606455
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread