2005-01-04 19:56:42

by David Howells

Subject: [PATCH] Don't include linux/a.out.h unnecessarily

The attached patch prevents unnecessary inclusion of linux/a.out.h since not
all archs support AOUT and thus may not have asm/a.out.h.

There was a patch included for this previously, but it seems to have been
dropped.

Signed-Off-By: David Howells <[email protected]>
---
warthog>diffstat aouth-2610mm1.diff
exec.c | 1 -
proc/kcore.c | 1 -
2 files changed, 2 deletions(-)

diff -uNrp /warthog/kernels/linux-2.6.10-mm1/fs/exec.c linux-2.6.10-mm1-frv/fs/exec.c
--- /warthog/kernels/linux-2.6.10-mm1/fs/exec.c 2005-01-04 11:15:20.000000000 +0000
+++ linux-2.6.10-mm1-frv/fs/exec.c 2005-01-04 13:23:24.000000000 +0000
@@ -26,7 +26,6 @@
#include <linux/slab.h>
#include <linux/file.h>
#include <linux/mman.h>
-#include <linux/a.out.h>
#include <linux/stat.h>
#include <linux/fcntl.h>
#include <linux/smp_lock.h>
diff -uNrp /warthog/kernels/linux-2.6.10-mm1/fs/proc/kcore.c linux-2.6.10-mm1-frv/fs/proc/kcore.c
--- /warthog/kernels/linux-2.6.10-mm1/fs/proc/kcore.c 2005-01-04 11:15:21.000000000 +0000
+++ linux-2.6.10-mm1-frv/fs/proc/kcore.c 2005-01-04 16:36:31.000000000 +0000
@@ -13,7 +13,6 @@
#include <linux/mm.h>
#include <linux/proc_fs.h>
#include <linux/user.h>
-#include <linux/a.out.h>
#include <linux/elf.h>
#include <linux/elfcore.h>
#include <linux/vmalloc.h>

2005-01-04 21:25:55

by Nathan Lynch

Subject: Re: [PATCH] Don't include linux/a.out.h unnecessarily

On Tue, 2005-01-04 at 13:51, David Howells wrote:
> The attached patch prevents unnecessary inclusion of linux/a.out.h since not
> all archs support AOUT and thus may not have asm/a.out.h.
>
> There was a patch included for this previously, but it seems to have been
> dropped.

Because it breaks the alpha build. There's a big #ifdef __alpha__ block
in search_binary_handler() which uses definitions from asm/a.out.h.

Sorry, I should have cc'd you on my original report:
http://article.gmane.org/gmane.linux.kernel/263714


Nathan