2005-02-10 20:11:53

by Timo Hoenig

[permalink] [raw]
Subject: [PATCH] Panasonic ACPI driver

Hi,

this is another ACPI driver for several Panasonic notebooks. The driver
provides support for hotkeys and enables access to other hardware like
reading/setting the LCD brightness.

Like the Sony ACPI driver--recently sent by Stelian Pop--it would be
good to to see this one to be integrated into the -mm tree, too.

The attached patch is against 2.6.11-rc3.

Thanks,

-- Timo

..............................................................
Timo H?nig <thoenig at suse dot de>
..................................................:: gpg ::...
Fingerprint: 0998 0ACA A1D2 2612 4D96 DD8B E03F 084B B305 4066


Attachments:
panasonic_acpi.diff (26.07 kB)

2005-02-15 15:08:02

by Brown, Len

[permalink] [raw]
Subject: Re: [ACPI] [PATCH] Panasonic ACPI driver

We should not include this driver in the kernel.

Rather than adding additional platform-specific drivers,
we should be migrating away from those that we already have
to simpler generic drivers for video and hot-keys -- where
the platform-dependent (naming) is done in user-space where
it is more extensible and supportable.

We've already got video.c, and I believe that we should start
to migrate to something like Luming's hot-key driver (see
earlier acpi-devel posts) in 2.6.12.

If a platform has some unique feature that no other platform
in the world has, then that justifies a platform specific driver
for that unique feature. But for the common features, the
community will be better served by the simpler generic kernel
drivers that work on more systems.

thanks,
-Len