2005-02-18 04:59:01

by Steve French

[permalink] [raw]
Subject: le conversion of posix acl fields

I saw your patch referenced in
http://marc.theaimsgroup.com/?l=linux-kernel&m=110859724430665&w=2

At first glance there is one odd place in the proposed patch:

- cifs_ace->cifs_e_perm = (__u8)cpu_to_le16(local_ace->e_perm);
- cifs_ace->cifs_e_tag = (__u8)cpu_to_le16(local_ace->e_tag);
+ cifs_ace->cifs_e_perm = (__u8)le16_to_cpu(local_ace->e_perm);
+ cifs_ace->cifs_e_tag = (__u8)le16_to_cpu(local_ace->e_tag);

If the field is le already then we should not convert it to cpu (since
cifs protocol assumes le format on the wire - it probably needs no
endian conversion in these two lines unless I am missing something)