To get the arcmsr driver working with CentOS/RHEL 4 and using the
facility to build kernel modules outside of the kernel source tree, I
found the attached patch was necessary to remove the dependencies on the
internal drivers/scsi/scsi*.h header files and to instead use the public
ones found under include/scsi/ which are provided by the kernel-*-devel
packages.
It builds, loads and appears to work with my limited testing on an
ARC1120. I was just wanting to know if this was the right way to fix it?
Once the driver is in the main kernel tree it's largely irrelevant, but
while CentOS/RHEL 4 use the older kernel without the driver it's a PITA
to maintain kernel packages with this one driver added, when a separate
package containing just the driver is much easier.
The patch is based on the 1.20.00.06 driver that was added to
2.6.11-mm4.
Thanks
Matt
On Sat, Mar 19, 2005 at 06:47:27PM +0000, Matt Dainty wrote:
> To get the arcmsr driver working with CentOS/RHEL 4 and using the
> facility to build kernel modules outside of the kernel source tree, I
> found the attached patch was necessary to remove the dependencies on the
> internal drivers/scsi/scsi*.h header files and to instead use the public
> ones found under include/scsi/ which are provided by the kernel-*-devel
> packages.
>
> It builds, loads and appears to work with my limited testing on an
> ARC1120. I was just wanting to know if this was the right way to fix it?
> Once the driver is in the main kernel tree it's largely irrelevant, but
> while CentOS/RHEL 4 use the older kernel without the driver it's a PITA
> to maintain kernel packages with this one driver added, when a separate
> package containing just the driver is much easier.
>
> The patch is based on the 1.20.00.06 driver that was added to
> 2.6.11-mm4.
Patch looks good, scsi.h is deprecated for a long time and I told
Erich to stop using it already.