2005-03-23 00:38:15

by Adrian Bunk

[permalink] [raw]
Subject: drivers/media/video/bt819.c: bt819_init: wrong array indexing

The Coverity checker found the following bug in array indexing in the
function bt819_init in drivers/media/video/bt819.c:

init[0x19*2-1] = decoder->norm == 0 ? 115 : 93;

I don't know whether the other array indexes in this function are
correct, but this is definitely wrong:
It indexes element 49 wile only the elements 0-43 are available.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed


2005-03-23 09:08:42

by Ronald S. Bultje

[permalink] [raw]
Subject: [PATCH] Re: drivers/media/video/bt819.c: bt819_init: wrong array indexing

On Wed, 2005-03-23 at 01:38, Adrian Bunk wrote:
> The Coverity checker found the following bug in array indexing in the
> function bt819_init in drivers/media/video/bt819.c:
>
> init[0x19*2-1] = decoder->norm == 0 ? 115 : 93;
>
> I don't know whether the other array indexes in this function are
> correct, but this is definitely wrong:
> It indexes element 49 wile only the elements 0-43 are available.

Auch, that is kinda embarrassing... Attached patch fixes it. Andrew, can
you please put this patch in the kernel?

Signed-off-by: Ronald S. Bultje <[email protected]>

Ronald

--
Ronald S. Bultje <[email protected]>


Attachments:
d (672.00 B)