2005-03-22 22:01:02

by Adrian Bunk

Subject: [2.6 patch] drivers/scsi/osst.c: remove unused code

Thanks to both the Coverity checker and GNU gcc, it was found that this
variable is completely unused.

Signed-off-by: Adrian Bunk <[email protected]>

--- linux-2.6.12-rc1-mm1-full/drivers/scsi/osst.c.old 2005-03-22 21:04:36.000000000 +0100
+++ linux-2.6.12-rc1-mm1-full/drivers/scsi/osst.c 2005-03-22 22:09:32.000000000 +0100
@@ -4770,9 +4770,6 @@ static int os_scsi_tape_close(struct ino
{
int result = 0;
struct osst_tape * STp = filp->private_data;
- struct scsi_request * SRpnt = NULL;
-
- if (SRpnt) scsi_release_request(SRpnt);

if (STp->door_locked == ST_LOCKED_AUTO)
do_door_lock(STp, 0);

2005-03-23 12:17:07

by Willem Riede

Subject: Re: [2.6 patch] drivers/scsi/osst.c: remove unused code

On 03/22/2005 04:59:48 PM, Adrian Bunk wrote:
> Thanks to both the Coverity checker and GNU gcc, it was found that this
> variable is completely unused.
>
> Signed-off-by: Adrian Bunk <[email protected]>

And it is so obvious when your attention is drawn to it.
The code that did use it moved to os_scsi_tape_flush() recently.

James, could you make this change in BK too, please?

Signed-off-by: Willem Riede <[email protected]>

> --- linux-2.6.12-rc1-mm1-full/drivers/scsi/osst.c.old 2005-03-22 21:04:36.000000000 +0100
> +++ linux-2.6.12-rc1-mm1-full/drivers/scsi/osst.c 2005-03-22 22:09:32.000000000 +0100
> @@ -4770,9 +4770,6 @@ static int os_scsi_tape_close(struct ino
> {
> int result = 0;
> struct osst_tape * STp = filp->private_data;
> - struct scsi_request * SRpnt = NULL;
> -
> - if (SRpnt) scsi_release_request(SRpnt);
>
> if (STp->door_locked == ST_LOCKED_AUTO)
> do_door_lock(STp, 0);
>