2005-04-04 02:15:56

by Shaohua Li

Subject: [RFC 4/6]Add kconfig for S3 SMP

Add kconfig for IA32 S3 SMP.

Thanks,
Shaohua

---

linux-2.6.11-root/kernel/power/Kconfig | 7 +++++++
1 files changed, 7 insertions(+)

diff -puN kernel/power/Kconfig~smp_s3_kconfig kernel/power/Kconfig
--- linux-2.6.11/kernel/power/Kconfig~smp_s3_kconfig 2005-03-31 10:49:57.156487160 +0800
+++ linux-2.6.11-root/kernel/power/Kconfig 2005-03-31 10:49:57.158486856 +0800
@@ -72,3 +72,10 @@ config PM_STD_PARTITION
suspended image to. It will simply pick the first available swap
device.

+config STR_SMP
+ bool "Suspend to RAM SMP support (EXPERIMENTAL)"
+ depends on EXPERIMENTAL && ACPI_SLEEP && !X86_64
+ depends on HOTPLUG_CPU
+ default y
+ ---help---
+ enable Suspend to RAM SMP support. Some HT systems require this.
_

2005-04-04 08:59:50

by Pavel Machek

Subject: Re: [RFC 4/6]Add kconfig for S3 SMP

Hi!

> Add kconfig for IA32 S3 SMP.
>
> Thanks,
> Shaohua
>
> ---
>
> linux-2.6.11-root/kernel/power/Kconfig | 7 +++++++
> 1 files changed, 7 insertions(+)
>
> diff -puN kernel/power/Kconfig~smp_s3_kconfig kernel/power/Kconfig
> --- linux-2.6.11/kernel/power/Kconfig~smp_s3_kconfig 2005-03-31 10:49:57.156487160 +0800
> +++ linux-2.6.11-root/kernel/power/Kconfig 2005-03-31 10:49:57.158486856 +0800
> @@ -72,3 +72,10 @@ config PM_STD_PARTITION
> suspended image to. It will simply pick the first available swap
> device.
>
> +config STR_SMP
> + bool "Suspend to RAM SMP support (EXPERIMENTAL)"
> + depends on EXPERIMENTAL && ACPI_SLEEP && !X86_64
> + depends on HOTPLUG_CPU
> + default y
> + ---help---
> + enable Suspend to RAM SMP support. Some HT systems require this.

Should this be config option? If we have ACPI_SLEEP and SMP set, we
should probably require this one (so that user does not have to
care).... Also name is "interesting", perhaps CONFIG_SMP_SLEEP or
something?

Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!

2005-04-04 09:17:29

by Shaohua Li

Subject: Re: [RFC 4/6]Add kconfig for S3 SMP

On Mon, 2005-04-04 at 16:59, Pavel Machek wrote:
> Hi!
>
> > Add kconfig for IA32 S3 SMP.
> >
> > Thanks,
> > Shaohua
> >
> > ---
> >
> > linux-2.6.11-root/kernel/power/Kconfig | 7 +++++++
> > 1 files changed, 7 insertions(+)
> >
> > diff -puN kernel/power/Kconfig~smp_s3_kconfig kernel/power/Kconfig
> > --- linux-2.6.11/kernel/power/Kconfig~smp_s3_kconfig 2005-03-31 10:49:57.156487160 +0800
> > +++ linux-2.6.11-root/kernel/power/Kconfig 2005-03-31 10:49:57.158486856 +0800
> > @@ -72,3 +72,10 @@ config PM_STD_PARTITION
> > suspended image to. It will simply pick the first available swap
> > device.
> >
> > +config STR_SMP
> > + bool "Suspend to RAM SMP support (EXPERIMENTAL)"
> > + depends on EXPERIMENTAL && ACPI_SLEEP && !X86_64
> > + depends on HOTPLUG_CPU
> > + default y
> > + ---help---
> > + enable Suspend to RAM SMP support. Some HT systems require this.
>
> Should this be config option? If we have ACPI_SLEEP and SMP set, we
> should probably require this one (so that user does not have to
> care)....
Sure, quite reasonable!

> Also name is "interesting", perhaps CONFIG_SMP_SLEEP or
> something?
Just because my patches break S4 currently. After we figure out how to
make both S3 and S4 work, I'll change it like you said.

Thanks,
Shaohua