2005-04-18 15:15:10

by Steve French

[permalink] [raw]
Subject: Re: [2.6 patch] remove cifs kcalloc

>On Mon, Apr 18, 2005 at 03:52:02AM +0200, Adrian Bunk wrote:
>> This patch removes cifs_kcalloc and replaces it with calls to
>> kcalloc(1, ...) .
>>
>> Signed-off-by: Adrian Bunk <[email protected]>
>As a followup patch you might want to check the return value
>of all those calls before blindly deferencing them.

I added checks for NULL return for kcalloc in the CIFS
development tree for the most important of the places
(since the NTLMSSP and SPNEGO routines are going to
need more changes anyway and are currently disabled
I did not add the NULL check to those three routines).

The patch can be seen at http://cifs.bkbits.net:8080/linux-2.5cifs/gnupatch@4263c100xtDHBiI8HNqfzh05uw0jOA