Hi,
Stelian Pop wrote:
> Confirmed on an Apple Powerbook too.
>
> For reference, the (already reverted) patch which needs to be applied is
> below.
>
> Signed-off-by: Stelian Pop <[email protected]>
>
> Index: linux-2.6.git/drivers/pci/setup-res.c
> ===================================================================
> --- linux-2.6.git.orig/drivers/pci/setup-res.c 2005-08-29 10:03:00.000000000 +0200
> +++ linux-2.6.git/drivers/pci/setup-res.c 2005-08-29 12:23:20.980716336 +0200
> @@ -53,9 +53,7 @@
> if (resno < 6) {
> reg = PCI_BASE_ADDRESS_0 + 4 * resno;
> } else if (resno == PCI_ROM_RESOURCE) {
> - if (!(res->flags & IORESOURCE_ROM_ENABLE))
> - return;
> - new |= PCI_ROM_ADDRESS_ENABLE;
> + new |= res->flags & IORESOURCE_ROM_ENABLE;
> reg = dev->rom_base_reg;
> } else {
> /* Hmm, non-standard resource. */
>
Sorry for my ignorance. Which tree was this reverted in? You are probably
aware that this bug made it into 2.6.13 (patch was not reverted there).
Daniel
Le jeudi 01 septembre 2005 ? 20:26 +0100, Daniel Drake a ?crit :
> Hi,
>
> Stelian Pop wrote:
> > Confirmed on an Apple Powerbook too.
> >
> > For reference, the (already reverted) patch which needs to be applied is
> > below.
> >
> > Signed-off-by: Stelian Pop <[email protected]>
> >
> > Index: linux-2.6.git/drivers/pci/setup-res.c
[...]
> Sorry for my ignorance. Which tree was this reverted in? You are probably
> aware that this bug made it into 2.6.13 (patch was not reverted there).
It must be my bad english but I wasn't implying that the patch was
reverted in 2.6.13 but that one should apply it (just apply, without -R,
because I didn't attach the original patch but a reversed version of it)
on a clean 2.6.13 tree in order to make it work. :)
However, a different fix (a real fix, not the workaround proposed above)
was discussed on lkml this week and BenH proposed a patch I haven't had
the chance to test yet (see http://lkml.org/lkml/2005/8/31/1 ).
Stelian.
--
Stelian Pop <[email protected]>