2005-10-14 16:16:00

by John Rigg

[permalink] [raw]
Subject: 2.6.14-rc4-rt4

The header on my last post seems to have been mangled so here it
is again...

Ingo, I just tried the patch you posted in reply to Badari Pulavarty's
boot crash message. I get an error when trying to patch 2.6.14-rc4-rt4:

patching file arch/x86_64/kernel/vsyscall.c
patch: **** malformed patch at line 11: notrace

John


2005-10-14 17:22:25

by Badari Pulavarty

[permalink] [raw]
Subject: Re: 2.6.14-rc4-rt4

On Fri, 2005-10-14 at 17:22 +0100, John Rigg wrote:
> The header on my last post seems to have been mangled so here it
> is again...
>
> Ingo, I just tried the patch you posted in reply to Badari Pulavarty's
> boot crash message. I get an error when trying to patch 2.6.14-rc4-rt4:
>
> patching file arch/x86_64/kernel/vsyscall.c
> patch: **** malformed patch at line 11: notrace
>

Try this..

I am able to apply cleanly. I am trying to see if it fixes my problem
or not.

Thanks,
Badari



Attachments:
notrace.patch (525.00 B)

2005-10-14 18:07:20

by John Rigg

[permalink] [raw]
Subject: Re: 2.6.14-rc4-rt4

On 14 October 2005 John Rigg wrote:
>Ingo, I just tried the patch you posted in reply to Badari Pulavarty's
>boot crash message. I get an error when trying to patch 2.6.14-rc4-rt4:
>
>patching file arch/x86_64/kernel/vsyscall.c
>patch: **** malformed patch at line 11: notrace

Excuse my stupidity - lynx wrapped the line when I printed it to a file.
Of course it patches cleanly with the \n removed.

John

2005-10-14 18:42:35

by John Rigg

[permalink] [raw]
Subject: Re: 2.6.14-rc4-rt4


On Fri October 14 Badari Pulavarty wrote:

>I am able to apply cleanly. I am trying to see if it fixes my problem
>or not.

Something in 2.6.14-rc4-rt4 breaks compilation with my config (with or
without the extra patch) with following error message:

CC kernel/ktimers.o
kernel/ktimers.c: In function 'check_ktimer_signal':
kernel/ktimers.c:1100: error: request for member 'tv' in something not a structure or union

Am about to try applying the change in the patch to -rt1, which I know
compiles.

John

>--- linux-2.6.14-rc4.org/arch/x86_64/kernel/vsyscall.c 2005-10-07 10:27:33.000000000 -0700
>+++ linux-2.6.14-rc4/arch/x86_64/kernel/vsyscall.c 2005-10-14 05:11:02.000000000 -0700
>@@ -34,7 +34,7 @@
> #include <asm/errno.h>
> #include <asm/io.h>
>
>-#define __vsyscall(nr) __attribute__ ((unused,__section__(".vsyscall_" #nr)))
>+#define __vsyscall(nr) __attribute__ ((unused,__section__(".vsyscall_" #nr))) notrace
> #define force_inline __attribute__((always_inline)) inline
>
> int __sysctl_vsyscall __section_sysctl_vsyscall = 1;
>

2005-10-14 19:08:12

by Badari Pulavarty

[permalink] [raw]
Subject: Re: 2.6.14-rc4-rt4

On Fri, 2005-10-14 at 19:48 +0100, John Rigg wrote:
> On Fri October 14 Badari Pulavarty wrote:
>
> >I am able to apply cleanly. I am trying to see if it fixes my problem
> >or not.
>
> Something in 2.6.14-rc4-rt4 breaks compilation with my config (with or
> without the extra patch) with following error message:
>
> CC kernel/ktimers.o
> kernel/ktimers.c: In function 'check_ktimer_signal':
> kernel/ktimers.c:1100: error: request for member 'tv' in something not a structure or union
>
> Am about to try applying the change in the patch to -rt1, which I know
> compiles.

It did work for me in -rt1. My machine boots fine with the patch.

Thanks,
Badari

2005-10-14 19:11:20

by Ingo Molnar

[permalink] [raw]
Subject: Re: 2.6.14-rc4-rt4


* John Rigg <[email protected]> wrote:

> >I am able to apply cleanly. I am trying to see if it fixes my problem
> >or not.
>
> Something in 2.6.14-rc4-rt4 breaks compilation with my config (with or
> without the extra patch) with following error message:
>
> CC kernel/ktimers.o
> kernel/ktimers.c: In function 'check_ktimer_signal':
> kernel/ktimers.c:1100: error: request for member 'tv' in something not a structure or union
>
> Am about to try applying the change in the patch to -rt1, which I know
> compiles.

-rt5 should fix that build problem.

Ingo