19-rpaphp-crashing.patch
This patch fixes a bug related to dlpar PHB add, after a PHB removal.
-- The crash was due to the PHB not having a pci_dn structure yet,
when the phb is being added.
This code survived testing, of adding and removeig the PHB and all slots
underneath it, 17 times so far, as of this writing.
Signed-off-by: Linas Vepstas <[email protected]>
emailed to
To: [email protected]
Cc: [email protected], [email protected],
[email protected], [email protected]
Subject: [PATCH] rpaphp: PCI Hotplug crash on PHB DLPAR add
on 4 October 2005
Index: linux-2.6.14-git3/drivers/pci/hotplug/rpadlpar_core.c
===================================================================
--- linux-2.6.14-git3.orig/drivers/pci/hotplug/rpadlpar_core.c 2005-11-02 14:29:02.115685162 -0600
+++ linux-2.6.14-git3/drivers/pci/hotplug/rpadlpar_core.c 2005-11-02 14:35:52.800111285 -0600
@@ -306,7 +306,7 @@
{
struct pci_controller *phb;
- if (PCI_DN(dn)->phb) {
+ if (PCI_DN(dn) && PCI_DN(dn)->phb) {
/* PHB already exists */
return -EINVAL;
}
> This patch fixes a bug related to dlpar PHB add, after a PHB removal.
This and patch 18 seem logically separate from the feature. This
complicates review and adds to an already large patch set. Could we
handle these separately?
Thanks-
John
On Fri, Nov 04, 2005 at 10:20:55AM -0600, John Rose was heard to remark:
> > This patch fixes a bug related to dlpar PHB add, after a PHB removal.
>
> This and patch 18 seem logically separate from the feature. This
> complicates review and adds to an already large patch set. Could we
> handle these separately?
I sent these in separetely, a month ago, as bug fixes for the dlpar
crashes in the pre-2.6.14 kernels, but these were never applied.
Since they're needed to get EEH to work, I just sent them in again
with this set. Yes, I'm aware that the patch you sent yesterday
fixes the same bug in almost the same way.
What you really want to concentrate on are patches 20 through 23
which mess with the guts of the rpaphp code. But again, these are
the same old patches, they have not changed since the submit last
month.
--linas