2005-11-22 15:59:13

by Robert Love

[permalink] [raw]
Subject: [patch] hdaps: missing an axis.


Greg,

Trivial patch to report both hdaps axises to the joystick device, not
just the X axis.

Patch originally by Eugeniy Meshcheryakov <[email protected]>.

Signed-off-by: Robert Love <[email protected]>

Robert Love


diff -urN a/drivers/hwmon/hdaps.c b/drivers/hwmon/hdaps.c
--- a/drivers/hwmon/hdaps.c Wed Nov 16 17:18:55 2005
+++ b/drivers/hwmon/hdaps.c Tue Nov 22 14:24:25 2005
@@ -570,7 +570,7 @@
hdaps_idev->evbit[0] = BIT(EV_ABS);
input_set_abs_params(hdaps_idev, ABS_X,
-256, 256, HDAPS_INPUT_FUZZ, HDAPS_INPUT_FLAT);
- input_set_abs_params(hdaps_idev, ABS_X,
+ input_set_abs_params(hdaps_idev, ABS_Y,
-256, 256, HDAPS_INPUT_FUZZ, HDAPS_INPUT_FLAT);

input_register_device(hdaps_idev);



2005-11-22 20:20:45

by Jean Delvare

[permalink] [raw]
Subject: Re: [patch] hdaps: missing an axis.

Hi Robert,

> Greg,
>
> Trivial patch to report both hdaps axises to the joystick device, not
> just the X axis.

That would rather be for me. I've enqueued it, thanks.

Looks like a bugfix we want in 2.6.15, right?

--
Jean Delvare

2005-11-22 20:56:50

by Robert Love

[permalink] [raw]
Subject: Re: [patch] hdaps: missing an axis.

On Tue, 2005-11-22 at 21:21 +0100, Jean Delvare wrote:

> That would rather be for me. I've enqueued it, thanks.

Ah, okay. Thanks. I did not know there were any driver subsystems that
Greg didn't maintain.

> Looks like a bugfix we want in 2.6.15, right?

It is not critical, but 2.6.15 would be nice. It is simple enough.

Robert Love