2006-01-10 04:06:09

by Adrian Bunk

[permalink] [raw]
Subject: [2.6 patch] VIDEO_SAA7134_ALSA shouldn't select SND_PCM_OSS

There's no reason for an ALSA driver to select an OSS legacy userspace
interface.


Signed-off-by: Adrian Bunk <[email protected]>

--- linux-2.6.15-mm2/drivers/media/video/saa7134/Kconfig.old 2006-01-10 02:59:30.000000000 +0100
+++ linux-2.6.15-mm2/drivers/media/video/saa7134/Kconfig 2006-01-10 03:02:57.000000000 +0100
@@ -15,7 +15,7 @@
config VIDEO_SAA7134_ALSA
tristate "Philips SAA7134 DMA audio support"
depends on VIDEO_SAA7134 && SND
- select SND_PCM_OSS
+ select SND_PCM
---help---
This is a video4linux driver for direct (DMA) audio in
Philips SAA713x based TV cards using ALSA


2006-01-10 04:14:09

by Lee Revell

[permalink] [raw]
Subject: Re: [2.6 patch] VIDEO_SAA7134_ALSA shouldn't select SND_PCM_OSS

On Tue, 2006-01-10 at 05:06 +0100, Adrian Bunk wrote:
> There's no reason for an ALSA driver to select an OSS legacy userspace
> interface.

Actually there is a reason. While OSS may be deprecated the OSS API is
not - ALSA is committed to supporting it for the forseeable future. And
as broken an interface as it is, a lot of people consider the sound
system broken if you can't just write() to /dev/dsp and have sound come
out.

Lee

2006-01-10 04:33:11

by Adrian Bunk

[permalink] [raw]
Subject: Re: [2.6 patch] VIDEO_SAA7134_ALSA shouldn't select SND_PCM_OSS

On Mon, Jan 09, 2006 at 11:14:05PM -0500, Lee Revell wrote:
> On Tue, 2006-01-10 at 05:06 +0100, Adrian Bunk wrote:
> > There's no reason for an ALSA driver to select an OSS legacy userspace
> > interface.
>
> Actually there is a reason. While OSS may be deprecated the OSS API is
> not - ALSA is committed to supporting it for the forseeable future. And
> as broken an interface as it is, a lot of people consider the sound
> system broken if you can't just write() to /dev/dsp and have sound come
> out.

No disagreement, but that's not the point.

SND_PCM_OSS gives an OSS API interface for userspace on top of ALSA.
ALSA drivers shouldn't care whether they are controlled directly
through ALSA or through a legacy OSS API on top of ALSA.

If someone wants to use SND_PCM_OSS that is fine, but the ALSA interface
to my saa7134 card is working fine, so why does it force me to compile a
legacy OSS API interface into the kernel?

> Lee

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

2006-01-10 04:44:01

by Lee Revell

[permalink] [raw]
Subject: Re: [2.6 patch] VIDEO_SAA7134_ALSA shouldn't select SND_PCM_OSS

On Tue, 2006-01-10 at 05:33 +0100, Adrian Bunk wrote:
> On Mon, Jan 09, 2006 at 11:14:05PM -0500, Lee Revell wrote:
> > On Tue, 2006-01-10 at 05:06 +0100, Adrian Bunk wrote:
> > > There's no reason for an ALSA driver to select an OSS legacy userspace
> > > interface.
> >
> > Actually there is a reason. While OSS may be deprecated the OSS API is
> > not - ALSA is committed to supporting it for the forseeable future. And
> > as broken an interface as it is, a lot of people consider the sound
> > system broken if you can't just write() to /dev/dsp and have sound come
> > out.
>
> No disagreement, but that's not the point.
>
> SND_PCM_OSS gives an OSS API interface for userspace on top of ALSA.
> ALSA drivers shouldn't care whether they are controlled directly
> through ALSA or through a legacy OSS API on top of ALSA.
>
> If someone wants to use SND_PCM_OSS that is fine, but the ALSA interface
> to my saa7134 card is working fine, so why does it force me to compile a
> legacy OSS API interface into the kernel?

OK, makes sense.

Lee

2006-01-10 18:57:29

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: Re: [2.6 patch] VIDEO_SAA7134_ALSA shouldn't select SND_PCM_OSS

Em Ter, 2006-01-10 ?s 05:06 +0100, Adrian Bunk escreveu:
> There's no reason for an ALSA driver to select an OSS legacy userspace
> interface.
>
>
> Signed-off-by: Adrian Bunk <[email protected]>
>
> --- linux-2.6.15-mm2/drivers/media/video/saa7134/Kconfig.old 2006-01-10 02:59:30.000000000 +0100
> +++ linux-2.6.15-mm2/drivers/media/video/saa7134/Kconfig 2006-01-10 03:02:57.000000000 +0100
> @@ -15,7 +15,7 @@
> config VIDEO_SAA7134_ALSA
> tristate "Philips SAA7134 DMA audio support"
> depends on VIDEO_SAA7134 && SND
> - select SND_PCM_OSS
> + select SND_PCM
> ---help---
> This is a video4linux driver for direct (DMA) audio in
> Philips SAA713x based TV cards using ALSA
Acked-by: Mauro Carvalho Chehab <[email protected]>

I'll apply at v4l-dvb git tree.
>
>
Cheers,
Mauro.