2006-01-19 16:35:06

by Adrian Bunk

[permalink] [raw]
Subject: [RFC: 2.6 patch] move ip2.c and ip2main.c to drivers/char/ip2/

Hi Michael,

I plan to do some cleanups for the ip2 driver including replacing the
#include'ing of .c files with building them separately and linking them
together.

As a preparation, this patch contains the following:
- move ip2.c and ip2main.c to drivers/char/ip2/
- rename ip2.c to ip2base.c (the module is still called ip2)
- adjust some #include's in the moved file to the new location

Is this patch OK for you?

Due to it's size (due to moving the files around) the patch is attached
gzip'ed.

diffstat output:

drivers/char/Makefile | 2
drivers/char/ip2.c | 109 -
drivers/char/ip2/Makefile | 8
drivers/char/ip2/ip2base.c | 109 +
drivers/char/ip2/ip2main.c | 3260 +++++++++++++++++++++++++++++++++++++
drivers/char/ip2main.c | 3260 -------------------------------------
6 files changed, 3378 insertions(+), 3370 deletions(-)



cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed


Attachments:
(No filename) (1.10 kB)
patch-ip2-move.gz (48.56 kB)
Download all attachments

2006-01-19 16:46:52

by Michael H. Warfield

[permalink] [raw]
Subject: Re: [RFC: 2.6 patch] move ip2.c and ip2main.c to drivers/char/ip2/

Hey Adrian,

On Thu, 2006-01-19 at 17:35 +0100, Adrian Bunk wrote:
> Hi Michael,

> I plan to do some cleanups for the ip2 driver including replacing the
> #include'ing of .c files with building them separately and linking them
> together.

> As a preparation, this patch contains the following:
> - move ip2.c and ip2main.c to drivers/char/ip2/
> - rename ip2.c to ip2base.c (the module is still called ip2)
> - adjust some #include's in the moved file to the new location

> Is this patch OK for you?

Yeah, go for it... Sounds good.

I've had some other patches in the queue but I've been sitting on them
until I can carve out some time to fix a spinlock problem. I'll rework
those based on what your doing.

Thanks!

Regards,
Mike

> Due to it's size (due to moving the files around) the patch is attached
> gzip'ed.
>
> diffstat output:
>
> drivers/char/Makefile | 2
> drivers/char/ip2.c | 109 -
> drivers/char/ip2/Makefile | 8
> drivers/char/ip2/ip2base.c | 109 +
> drivers/char/ip2/ip2main.c | 3260 +++++++++++++++++++++++++++++++++++++
> drivers/char/ip2main.c | 3260 -------------------------------------
> 6 files changed, 3378 insertions(+), 3370 deletions(-)
>
>
>
> cu
> Adrian
>
> --
>
> "Is there not promise of rain?" Ling Tan asked suddenly out
> of the darkness. There had been need of rain for many days.
> "Only a promise," Lao Er said.
> Pearl S. Buck - Dragon Seed
>
>
--
Michael H. Warfield (AI4NB) | (770) 985-6132 | [email protected]
/\/\|=mhw=|\/\/ | (678) 463-0932 | http://www.wittsend.com/mhw/
NIC whois: MHW9 | An optimist believes we live in the best of all
PGP Key: 0xDF1DD471 | possible worlds. A pessimist is sure of it!


Attachments:
signature.asc (307.00 B)
This is a digitally signed message part