2006-01-20 18:25:22

by Fernando Lopez-Lezcano

Subject: 2.6.15-rt6: network driver disabled interrupts: skge_xmit_frame

Tons of these messages when I try out the skge network driver under
2.6.15-rt6 (instead of the sk98lin driver):

network driver disabled interrupts: skge_xmit_frame+0x0/0x330 [skge]

Any fixes I could try?
Thanks...
-- Fernando

2006-01-20 19:23:56

by Ingo Molnar

Subject: Re: 2.6.15-rt6: network driver disabled interrupts: skge_xmit_frame

* Fernando Lopez-Lezcano <[email protected]> wrote:

> Tons of these messages when I try out the skge network driver under
> 2.6.15-rt6 (instead of the sk98lin driver):
>
> network driver disabled interrupts: skge_xmit_frame+0x0/0x330 [skge]
>
> Any fixes I could try?

could you try the one below ontop of -rt8?

Ingo

Index: linux-rt.q/drivers/net/skge.c
===================================================================
--- linux-rt.q.orig/drivers/net/skge.c
+++ linux-rt.q/drivers/net/skge.c
@@ -2272,12 +2272,9 @@ static int skge_xmit_frame(struct sk_buf
if (!skb)
return NETDEV_TX_OK;

- local_irq_save(flags);
- if (!spin_trylock(&skge->tx_lock)) {
+ if (!spin_trylock_irqsave(&skge->tx_lock))
/* Collision - tell upper layer to requeue */
- local_irq_restore(flags);
return NETDEV_TX_LOCKED;
- }

if (unlikely(skge->tx_avail < skb_shinfo(skb)->nr_frags +1)) {
if (!netif_queue_stopped(dev)) {