2006-08-07 15:08:10

by Martin Schwidefsky

[permalink] [raw]
Subject: [patch] s390: hypfs comment cleanup.

From: Michael Holzheu <[email protected]>

[S390] hypfs comment cleanup.

Correct some comments in the hypervisor filesystem.

Signed-off-by: Michael Holzheu <[email protected]>
Signed-off-by: Martin Schwidefsky <[email protected]>
---

arch/s390/hypfs/hypfs.h | 2 +-
arch/s390/hypfs/hypfs_diag.c | 2 +-
arch/s390/hypfs/hypfs_diag.h | 2 +-
arch/s390/hypfs/inode.c | 2 +-
drivers/base/hypervisor.c | 3 ++-
5 files changed, 6 insertions(+), 5 deletions(-)

diff -urpN linux-2.6/arch/s390/hypfs/hypfs_diag.c linux-2.6-patched/arch/s390/hypfs/hypfs_diag.c
--- linux-2.6/arch/s390/hypfs/hypfs_diag.c 2006-08-07 14:14:23.000000000 +0200
+++ linux-2.6-patched/arch/s390/hypfs/hypfs_diag.c 2006-08-07 14:15:00.000000000 +0200
@@ -1,5 +1,5 @@
/*
- * fs/hypfs/hypfs_diag.c
+ * arch/s390/hypfs/hypfs_diag.c
* Hypervisor filesystem for Linux on s390. Diag 204 and 224
* implementation.
*
diff -urpN linux-2.6/arch/s390/hypfs/hypfs_diag.h linux-2.6-patched/arch/s390/hypfs/hypfs_diag.h
--- linux-2.6/arch/s390/hypfs/hypfs_diag.h 2006-08-07 14:14:23.000000000 +0200
+++ linux-2.6-patched/arch/s390/hypfs/hypfs_diag.h 2006-08-07 14:15:00.000000000 +0200
@@ -1,5 +1,5 @@
/*
- * fs/hypfs/hypfs_diag.h
+ * arch/s390/hypfs_diag.h
* Hypervisor filesystem for Linux on s390.
*
* Copyright (C) IBM Corp. 2006
diff -urpN linux-2.6/arch/s390/hypfs/hypfs.h linux-2.6-patched/arch/s390/hypfs/hypfs.h
--- linux-2.6/arch/s390/hypfs/hypfs.h 2006-08-07 14:14:23.000000000 +0200
+++ linux-2.6-patched/arch/s390/hypfs/hypfs.h 2006-08-07 14:15:00.000000000 +0200
@@ -1,5 +1,5 @@
/*
- * fs/hypfs/hypfs.h
+ * arch/s390/hypfs/hypfs.h
* Hypervisor filesystem for Linux on s390.
*
* Copyright (C) IBM Corp. 2006
diff -urpN linux-2.6/arch/s390/hypfs/inode.c linux-2.6-patched/arch/s390/hypfs/inode.c
--- linux-2.6/arch/s390/hypfs/inode.c 2006-08-07 14:14:23.000000000 +0200
+++ linux-2.6-patched/arch/s390/hypfs/inode.c 2006-08-07 14:15:00.000000000 +0200
@@ -1,5 +1,5 @@
/*
- * fs/hypfs/inode.c
+ * arch/s390/hypfs/inode.c
* Hypervisor filesystem for Linux on s390.
*
* Copyright (C) IBM Corp. 2006
diff -urpN linux-2.6/drivers/base/hypervisor.c linux-2.6-patched/drivers/base/hypervisor.c
--- linux-2.6/drivers/base/hypervisor.c 2006-08-07 14:14:24.000000000 +0200
+++ linux-2.6-patched/drivers/base/hypervisor.c 2006-08-07 14:15:00.000000000 +0200
@@ -1,8 +1,9 @@
/*
* hypervisor.c - /sys/hypervisor subsystem.
*
- * This file is released under the GPLv2
+ * Copyright (C) IBM Corp. 2006
*
+ * This file is released under the GPLv2
*/

#include <linux/kobject.h>


2006-08-07 16:03:28

by Alexey Dobriyan

[permalink] [raw]
Subject: Re: [patch] s390: hypfs comment cleanup.

On Mon, Aug 07, 2006 at 05:08:07PM +0200, Martin Schwidefsky wrote:
> [S390] hypfs comment cleanup.

Please, just delete file lines as they carry no additional info.

> --- linux-2.6/arch/s390/hypfs/hypfs_diag.c
> +++ linux-2.6-patched/arch/s390/hypfs/hypfs_diag.c
> @@ -1,5 +1,5 @@
> /*
> - * fs/hypfs/hypfs_diag.c
> + * arch/s390/hypfs/hypfs_diag.c
> * Hypervisor filesystem for Linux on s390. Diag 204 and 224
> * implementation.
> *

> --- linux-2.6/arch/s390/hypfs/hypfs_diag.h
> +++ linux-2.6-patched/arch/s390/hypfs/hypfs_diag.h
> @@ -1,5 +1,5 @@
> /*
> - * fs/hypfs/hypfs_diag.h
> + * arch/s390/hypfs_diag.h
> * Hypervisor filesystem for Linux on s390.
> *
> * Copyright (C) IBM Corp. 2006

> --- linux-2.6/arch/s390/hypfs/hypfs.h
> +++ linux-2.6-patched/arch/s390/hypfs/hypfs.h
> @@ -1,5 +1,5 @@
> /*
> - * fs/hypfs/hypfs.h
> + * arch/s390/hypfs/hypfs.h
> * Hypervisor filesystem for Linux on s390.
> *
> * Copyright (C) IBM Corp. 2006

> --- linux-2.6/arch/s390/hypfs/inode.c
> +++ linux-2.6-patched/arch/s390/hypfs/inode.c
> @@ -1,5 +1,5 @@
> /*
> - * fs/hypfs/inode.c
> + * arch/s390/hypfs/inode.c

2006-08-07 16:22:43

by Martin Schwidefsky

[permalink] [raw]
Subject: Re: [patch] s390: hypfs comment cleanup.

On Mon, 2006-08-07 at 20:03 +0400, Alexey Dobriyan wrote:
> On Mon, Aug 07, 2006 at 05:08:07PM +0200, Martin Schwidefsky wrote:
> > [S390] hypfs comment cleanup.
>
> Please, just delete file lines as they carry no additional info.

Hmm, it is common pratice to have the path of the source file in the
comment. If we decide to remove all these path from the comments, this
would be a perfect jobs for the kernel janitors. For now I want to keep
things consistent with the majority of the files in arch/s390.

One thing in favor of having the path in the comment: if you print the
file or copy it somewhere you still know where it came from. On the
other hand who prints files from the linux source tree ?

--
blue skies,
Martin.

Martin Schwidefsky
Linux for zSeries Development & Services
IBM Deutschland Entwicklung GmbH

"Reality continues to ruin my life." - Calvin.